The value of Drupal::VERSION is set to '8.1.4-dev' in the latest tar file and also when installing this release with composer.

CommentFileSizeAuthor
#6 drupal-8.1.4-wrong_version_number-2761553-6-do-not-test.patch226 byteshswong3i
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jurgenhaas created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Looks like I forgot to actually commit the version number change (i.e. I changed the version number locally, tagged, then changed it to dev and did the 'back to dev' commit).

Do people have opinions on whether this is worth a paper bag release or not?

mariagwyn’s picture

mariagwyn CreditAttribution: mariagwyn commented

For what it is worth, it is causing my sites to register as 'Drupal Core Unknown' on the update page.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
CreditAttribution: jurgenhaas at PARAGON Executive Services GmbH commented

The consequences if the current situation are misleading messages on the status page and the update overview. Those with automated workflows will potentially be affected in addition such that their processes will be downloading D8 core again without any change.

None of this is a real problem, if the site administrators were aware of the reason behind it and that it doesn't really matter. However, I doubt that they all know as there should already be north of 100k D8 sites in the wild.

Ramdas Gaikar’s picture

Ramdas Gaikar CreditAttribution: Ramdas Gaikar at Intelliswift commented

Hi All,

The Drupal Core version is specified in the core/lib/Drupal.php file at line no 84.

const VERSION = '8.1.5-dev';

Currently on git branch of 1.x version :

git clone --branch 8.1.x https://git.drupal.org/project/drupal.git, 8.1.5-dev version is defined.

So for 8.1.4, I dont know how should I apply patch.

If someone knows they can post patch for this.

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
FileSize
drupal-8.1.4-wrong_version_number-2761553-6-do-not-test.patch226 bytes

Patch attached but mark as do-not-test, since it will only apply to 8.1.4 tagged release, e.g. download 8.1.4 with tar.gz from drupal.org, or by composer.json which pinned to "drupal/core": "~8.1".

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Active » Fixed

I've released 8.1.5

andrewmacpherson’s picture

andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commented
Status: Fixed » Needs work

8.1.5 correctly reports it's verison number now, but there are a few confusing things in the 8.1.5 release notes:

  • It still says that it incorrectly reports it's version number. This can be removed from the 8.1.5 release notes as it doesn't apply.
  • The section about known issues on specific hosting environments say 8.1.4. This ought to say 8.1.5
  • "All changes since the last release" - heading would be improved by saying all changes since 8.1.3

I'm assuming release notes nodes can be edited by a core maintainer after release?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs work » Fixed

Thanks, just updated the release notes for those.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.