If I disable the display of the title field on a view_mode, it still appears.

I am working on a patch

CommentFileSizeAuthor
#6 title-disabled_title_still_appears-2759219-6.patch3.26 KBsylvainm
#3 title-disabled_title_still_appears-2759219-3.patch1.63 KBsylvainm

Comments

SylvainM created an issue. See original summary.

sylvainm’s picture

sylvainm commented
Title: Disabled title appears on a view_mode » Disabled title still appears on a view_mode
Issue summary: View changes
sylvainm’s picture

sylvainm commented
Status: Active » Needs review
StatusFileSize
new title-disabled_title_still_appears-2759219-3.patch1.63 KB

With attached patch, it works good for me

Status: Needs review » Needs work

The last submitted patch, 3: title-disabled_title_still_appears-2759219-3.patch, failed testing.

sylvainm’s picture

sylvainm commented
Status: Needs work » Needs review

I locally launched the test without the patch and it fails with the same error, so I don't think it is related to this patch.

Looking at the failing test, I wonder if the failing line (53) shouldn't use assertNoRaw instead of assertRaw

sylvainm’s picture

sylvainm commented
StatusFileSize
new title-disabled_title_still_appears-2759219-6.patch3.26 KB

Hum, not sure why, but this worked and this does no more work...

With this patch, it is now good...

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

#6 works fine!

NerOcrO’s picture

NerOcrO commented
Status: Needs review » Reviewed & tested by the community

Look's good!

alex_optim’s picture

alex_optim
Location Tallinn
commented

+1

pifagor’s picture

pifagor commented

  • pifagor committed ded4e36 on 8.x-2.x authored by SylvainM 
    Issue #2759219 by SylvainM, leymannx, NerOcrO, alex_optim, pifagor:...
pifagor’s picture

pifagor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.