Content type, Vocabularies and Menus names are not translated

@miiimooo Is this problem solved ? Because the problem is still there with Release 8.x-1.17.

Patch works for me in 8.x-1.17.

Thanks for the patch! Works for me!

\Drupal::entityTypeManager()->getStorage('node_type')->loadMultiple() already returns the localized title/description when using configuration translation. Therefore, t($type->label()) can lead to unexpected side effects, e.g. declaring already translated configuration titles as source strings for interface translation. As far as I know, we should not run the returned label through translation again.

This does create the effect, however, that links are always displayed in the interface language used during menu/links cache rebuild. I don't quite know how to fix this, though ...

I have the same problem. In my case, patch #5 doesn't work with Drupal 8.2.6.

It's a critical issue for multilanguage sites.

Edit: I expand my answer. It works but only if I do "Rebuild menu". But to display in each language I have to change interface language and then "Rebuild menu". It only works in the current language, to see it in another language I have to do "Rebuild menu" again. And If I do "Flush all caches" I will get the menu in other language (the site default language).

The problem is that we can't use string translation (where translation happens very late, during rendering => post caching) because the entities use configuration translation (where translation happens very early, when loading the configuration => pre caching). This in combination with MenuLinkDefault/MenuLinkBase caching everything statically causes issues. We'd probably need a cache context of languages:language_interface to get this working.

I can see two options on how we could resolve this, both are neither nice nor short: Either provide a new MenuLink type that can cache by language context, or create a new StringTranslator for the TranslationManager that pulls translations from configuration and would allow us to use TranslatableMarkup as suggested in hook_menu_links_discovered_alter. The first should be the easier one and might be avoided if we could manage to get a Core-patch that allows definitions of MenuLinkDefault to provide caching information, maybe via metadata?

It looks like this patch is already included in the submodule admin_toolbar_tools.

I agree that this possibly isn't the best way to translate these items. But I also needed Vocabularies and Menu items to be translated. So I've passed these through the t-function as well.

And a patch for everyone on 8.x-1.19

I think that we need a patch even if it's an ugly one:) I created it according to the latest dev version.

Committed in latest dev version. Thanks to all.

Rerolling the patch.

This was changed in http://cgit.drupalcode.org/admin_toolbar/diff/admin_toolbar_tools/admin_...

I edited the patch #21 because it doesn't work on Admin toolbar 1.27 version. Feel free to review it !