As per coding standard (https://www.drupal.org/coding-standards), issues found in

  • search404/src/Controller/Search404Controller.php
  • search404/src/Form/Search404Settings.php
  • search404/search404.links.menu.yml
CommentFileSizeAuthor
#7 edit_coding_standard-2759037-1.patch7.25 KBfathimathsajila
#4 2759037-search404-coding-standard-issues.patch13.71 KBakhilavnair
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akhilavnair_zyxware created an issue. See original summary.

akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
CreditAttribution: akhilavnair at Zyxware Technologies commented
Title: Namespaced classes, interfaces and traits should not begin with a file doc comment. » Coding standard issues
Issue summary: View changes
Related issues: -#2758439: Remove @file tag docblock from all the .php files.
akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
CreditAttribution: akhilavnair at Zyxware Technologies commented
Issue summary: View changes
akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
CreditAttribution: akhilavnair at Zyxware Technologies commented
Status: Active » Needs review
FileSize
2759037-search404-coding-standard-issues.patch13.71 KB

Added a patch to fix coding standards issues found in

  • README.txt
  • search404.install
  • search404.links.menu.yml
  • src/Controller/Search404Controller.php
  • src/Form/Search404Settings.php
anish_zyxware’s picture

anish_zyxware CreditAttribution: anish_zyxware at Zyxware Technologies commented

I am not sure how the renaming of functions have the effect on module. I am putting this on hold till that's fully tested and confirmed.

anish.a’s picture

anish.a CreditAttribution: anish.a as a volunteer commented
Issue tags: +Needs manual testing
fathimathsajila’s picture

fathimathsajila CreditAttribution: fathimathsajila at Zyxware Technologies commented
FileSize
edit_coding_standard-2759037-1.patch7.25 KB

Fixed coding standard issues.

mslabba_zyxware’s picture

mslabba_zyxware CreditAttribution: mslabba_zyxware at Zyxware Technologies commented
Assigned: akhilavnair » Unassigned
Status: Needs review » Fixed
Issue tags: -Needs manual testing

Reviewed and successfully merged the patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.