Got this error on a clean D7 install without the image module enabled. I'd imagine on most sites the image module will be enabled, but it shouldn't be a dependency.

CommentFileSizeAuthor
#8 2758119-upload-replace-image-flush-dependency-8.patch668 bytesDru18
#4 2758119-upload-replace-image-flush-dependency-4.patch891 byteselijah lynn

Comments

jay-dee-ess created an issue. See original summary.

vinayak kothule’s picture

vinayak kothule commented

Hi jay-dee-ess,

I am unable to reproduce this issue. Can you kindly elaborate more or provide detailed steps you took ?

I have checked module file code and unable to find the function image_path_flush() so there is no need to add dependency of image module.

Thanks !

jay-dee-ess’s picture

jay-dee-ess commented
Related issues: +#1115484: Parameter 1 to upload_replace_file_update() expected to be a reference, value given in module_invoke_all()

Hi Vinayak,

This is related to the recent patch committed to the dev version. I added it as a related issue here.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Status: Active » Needs review
StatusFileSize
new 2758119-upload-replace-image-flush-dependency-4.patch891 bytes

This is valid Vinayak, it is on HEAD right now. I think we just need to add an if (module_exists('image')) around those flushes. Let's try this patch out.

jay-dee-ess’s picture

jay-dee-ess commented

Might be a minor difference, but it seems like the image flush should only happen for certain file types rather than if the image module is enabled?

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented

Good point, we should update so it is just flushing image file types.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Status: Needs review » Needs work
Dru18’s picture

Dru18 commented
StatusFileSize
new 2758119-upload-replace-image-flush-dependency-8.patch668 bytes

I guess the above patch works. But this is a slight variation with checking the type field in the table instead of module.