Some time between June 24th and June 28th there were chnages to the Drupal 8.2 core which have caused previously passing tests to fail. See https://www.drupal.org/pift-ci-job/349277

CommentFileSizeAuthor
#3 2757625-3.change_assertraw_to_asserttext_in_tests.patch6.84 KBjonathan1055

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented

The failing tests are when editing and saving a node and the assertion looks for the message text. It used to be '@type %title has been updated.' with %title emphasised (italics). That's how it is in 8.1 still, but in 8.2 (some time between 24th and 28th June) the title has become a link to the node. Hence the calls to assertRaw now fail due to the extra html link.

Two submitted patches are failing due to this - see related issues.

I'll get a patch here soon, to fix the existing codebase, before we do any more work on those (or any other) 8.x issues.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new 2757625-3.change_assertraw_to_asserttext_in_tests.patch6.84 KB

Three test classes used assertRaw for the save message. I have changed these to assertText so that no html is checked, only the text. All tests pass on my localhost running 8.2-dev of 28th June.

  • jonathan1055 committed c59b870 on 8.x-1.x 
    Issue #2757625 by jonathan1055: Previously passing tests now fail in...
jonathan1055’s picture

jonathan1055 commented
Title: Previously passing tests now fail in Drupal 8.2 » Previously passing tests now fail in Drupal 8.2 - Change assertRaw to assertText
Assigned: jonathan1055 » Unassigned
Status: Needs review » Fixed

The committed codebase iss fully passing again.

For info, the core issue which caused the problem was #2513402: Any time a user creates a thing and saves, display a link to the thing created in the status. and here is the specific commit to NodeForm.php

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.