Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I believe this builder is a holdover from the original panels in d8 code: #2340999: Implement "display renderer" plugin type (now called "display builder")
Since we implemented our own IPE builder, is the editor display builder even needed anymore? The code is empty and nothing seems to be referencing it.
We will need to write an update hook that changes them to another builder.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 2757331-redirect-editor-builder-14.patch | 1.05 KB | japerry |
Comments
Comment #2
dsnopekWe shouldn't let users select it. But it'd be nice to still have it and use it for laying out blocks in the admin UI - this would allow us to show the blocks in the actual layout that the panel is using, rather than just having them on a flat list.
Comment #3
EclipseGc CreditAttribution: EclipseGc commentedThis class currently does NOTHING. It just extends the base class (literally just extends it). At this point, if we intend to add additional features to an administrative backend, I think Standard's the place to do it. No?
Eclipse
Comment #4
dsnopekRight, it was never finished, because it was unclear how the admin UI's would work. We could remove it and then create a new issue to add it back and have it actually do something? :-)
No, I think there's still a place for the Editor builder (just as there was in D7 and older) to add any extra markup and fields for the admin UI. However, it should never actually be selectable by users for a saved Panels display.
Comment #5
EclipseGc CreditAttribution: EclipseGc commentedOk, so maybe illuminate more what you're thinking here? I'm definitely confused.
Eclipse
Comment #6
dsnopekCheck out the Editor renderer in D7. I'm thinking we'd do the same thing in D8.
For now, I'd be fine with this issue removing the Editor builder, and then making a new issue to fully implement it.
Comment #8
japerryRemoved. this should be a good UX improvement for new users to Panels.
Comment #9
dsnopekEr, now that Panels is -beta, shouldn't this have come with some way for handling sites where the user may have selected "Editor"? I'm not sure we can do an update hook (because Panels isn't in control of its storage) but maybe something when the PanelsDisplayVariant is being initialized to check for "editor" and replace it with "standard"?
Comment #10
giuliovale CreditAttribution: giuliovale commentedAfter this commit there are some:
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "editor" plugin does not exist.
Any help to fix this?
Edit: ok simple fix:
- restore EditorDisplayBuilder.php
- change settings to standard for wrong page
- delete EditorDisplayBuilder.php
+1 for #9
Comment #11
japerryLooks like we'll look in the DisplayBuilderManager and swap in 'standard' for 'editor' before it creates the instance.
Comment #12
dsnopekSince this affects BC, we need to fix it before the next -beta release
Comment #13
japerryComment #14
japerryAfter talking with Kris and David, I think this is probably the best approach to avoiding the editor plugin not found error.
Comment #17
japerryPushed this fix up in prep for the next beta.
Comment #18
mlhess CreditAttribution: mlhess as a volunteer commented