As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#5 2757089_5.patch4.5 KBvishalkhialani
#2 2757089-2.patch2.57 KBvinay15

Comments

Vinay15 created an issue. See original summary.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Assigned: vinay15 » Unassigned
Status: Active » Needs review
StatusFileSize
new 2757089-2.patch2.57 KB

Removed @file docblock.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Thanks. There are still @file docblocks in files in the src folder.

vishalkhialani’s picture

vishalkhialani commented
Assigned: Unassigned » vishalkhialani
Status: Needs work » Active
vishalkhialani’s picture

vishalkhialani commented
StatusFileSize
new 2757089_5.patch4.5 KB

Hi! Here is an updated patch with the file tag block removed from the following files as well:

src/Adapter.php
src/Form/AdminForm.php
src/MailsystemManager.php
src/MailsystemServiceProvider.php
src/Tests/AdminFormSettingsTest.php
src/Tests/MailsystemTestThemeTest.php

vishalkhialani’s picture

vishalkhialani commented
Assigned: vishalkhialani » Unassigned
Status: Active » Needs review
nehakhadke’s picture

nehakhadke commented
Status: Needs review » Fixed
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Fixed » Needs review

This has not been committed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Now it is.

  • Berdir committed 39147ec on 8.x-4.x authored by vishalkhialani 
    Issue #2757089 by vishalkhialani, Vinay15: Remove @file tag docblock...
nehakhadke’s picture

nehakhadke commented
nehakhadke’s picture

nehakhadke commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.