Avoid #prefix and #suffix in buildRegions(), use #theme_wrappers instead [#2756613]

Problem/Motivation

The currently used #prefix and #suffix at the $build[$region] should be avoided. This practice has the possibility that something goes wrong (mistyped/accidentally missing opening or closing tags) and it's impossible to add new attributes (even classes) to the wrapper element without setting #prefix again. If somebody doesn't need the wrapper, he/she has to unset #prefix and suffix too.

Proposed resolution

Use #theme_wrappers instead of the current solution

Remaining tasks

~~Provide a patch.~~

User interface changes

Nothing.

API changes

Nothing.

Data model changes

Nothing.

Comment	File	Size	Author
#8	page_manager-avoid_prefix_suffix-2756613-8.patch	1.25 KB	huzooka
#5	use_theme_wrapper-2756613-5.patch	723 bytes	hardikpandya
#2	page_manager-avoid_prefix_suffix-2756613-2.patch	844 bytes	huzooka

Issue fork page_manager-2756613

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2756613-avoid-prefix-and changes, plain diff MR !15
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

27 June 2016 at 18:50

huzooka created an issue. See original summary.

Comment #2

huzooka

Hungarian

Hungary 🇭🇺🇪🇺

commented 27 June 2016 at 19:00

Issue summary:	View changes
Status:	Active	» Needs review

Status	File	Size
new	page_manager-avoid_prefix_suffix-2756613-2.patch	844 bytes

Patch attached.

Comment #3

27 June 2016 at 19:03

Status:

Needs review

» Needs work

The last submitted patch, 2: page_manager-avoid_prefix_suffix-2756613-2.patch, failed testing.

Comment #4

sneha_surve commented 27 August 2016 at 15:22

Assigned:

Unassigned

» sneha_surve

Comment #5

hardikpandya commented 17 October 2016 at 13:06

Assigned:	sneha_surve	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	use_theme_wrapper-2756613-5.patch	723 bytes

Added patch.

Comment #6

joville commented 26 October 2016 at 18:51

I found this following issue which means that there is a plan to remove #theme_wrappers in core: https://www.drupal.org/node/2714509

Comment #7

7 December 2016 at 23:28

Status:

Needs review

» Needs work

The last submitted patch, 5: use_theme_wrapper-2756613-5.patch, failed testing.

Comment #8

huzooka

Hungarian

Hungary 🇭🇺🇪🇺

commented 10 February 2017 at 11:41

Status:

Needs work

» Needs review

Status	File	Size
new	page_manager-avoid_prefix_suffix-2756613-8.patch	1.25 KB

Tests fails happen because of the xPath() except only the "block-region-top" CSS class.

My problem is about that I should be able to alter the wrapper (or remove it completely if I want to). With this patch, the regions of the PageBlockDisplayVariant would get "real" regions, which means that e.g. they get pre-processable by template_preprocess_hook(). But that also means that they get further classes (region and region-top) and the xPath() wont found what it searches for.

So, because of that, I'd change xPaths to cssSelects.

Do you have any kind of feedback what should I do?