Allowed Entity Embed Display plugins does not work [#2756473]

We created a custom entity embed button, and selected display plugins under the "Allowed Entity Embed Display plugins" option. However, selecting any options from this feature causes entity embedding to break.

For example, after selecting an image to embed and clicking "next", the following error is displayed:

No display options available for the selected entity. Please select another entity.

The modal screen that allows for selection of a display and view mode is never shown.

Comment	File	Size	Author
#5	custom_entity_embed_button_form_7.x-3.x-dev.png	87.48 KB	sgdev
#4	file_embed_creation.png	26.86 KB	marcoscano
#3	entity_embed-modal_success.png	32.06 KB	sgdev
#3	entity_embed-modal_error.png	49.05 KB	sgdev

Comments

Comment #1

27 June 2016 at 15:25

ron_s created an issue. See original summary.

Comment #2

marcoscano

Portuguese, Brazil

Barcelona, Spain

commented 27 June 2016 at 17:33

Category:

Bug report

» Support request

Hello @ron_s

Can you please provide steps to reproduce the bug?

The following steps are needed to create an embed button, which I have just tested with the latest -dev version of entity_embed without problems:

1- Go to /admin/config/content/embed and add a new embed button
2- Give it a Label, select Type: Entity, and then the entity/bundle you want to embed. (For example here: Content + Basic Page). Select here also the Display plugins, for example, let's select only "Rendered Entity" and "Label"
3- Go to the format config page (for example /admin/config/content/formats/manage/basic_html for editing the "Basic HTML" format), and drag the button you created to the Active toolbar (make sure you drag the one you have created, if you are not using a custom icon). Make sure you select the checkbox "Display embedded entities", and if you have active the filter "Limit allowed HTML...", also make sure that the embed tags are present in the field "Allowed HTML tags". This last step is not needed if you are using a recent version of the module, nowadays this gets updated when you drag the button to the Active toolbar.
4- Create some content with the ckeditor and choose an existing Basic Page on the autocomplete. You will see that in the modal window that appears after you choose the node to embed, the Display options are restricted to the ones you defined in step 2. (In this case, only "Rendered entity" and "Label".)

Are you doing anything different?

Also, please note that the "Display plugins" description on the button creation form indicates that
Note that these are the plugins which are allowed for this entity type, all of these might not be available for the selected entity.

Comment #3

sgdev commented 27 June 2016 at 18:26

Category:	Support request	» Bug report
Issue summary:	View changes

Status	File	Size
new	entity_embed-modal_error.png	49.05 KB
new	entity_embed-modal_success.png	32.06 KB

@marcoscano, I appreciate the detailed response, but I understand how the module works. This is definitely a bug.

Here are the steps to reproduce:

Go to /admin/config/content/embed and add a new embed button.
Give it a label of "Image", select entity type of "File", and a file bundle of "Image".
Set "Allowed Entity Embed Display plugins" to be "Rendered entity", "Rendered file", "Image", or "Picture" (using the Picture module). Any of these should work. Have tried each one separately, and none of them work.
Perform all the steps you mentioned about format config... I'm not going to repeat them here, because this issue is specifically with Allowed Entity Embed Display plugins.
Create some content when one of the plugins is selected, and modal window returns an error (see attached).
Return to the embed button config, edit the "image" custom button, and remove selected "Allowed Entity Embed Display plugins".
Create some content and modal window works as expected (see attached).

Comment #4

marcoscano

Portuguese, Brazil

Barcelona, Spain

commented 28 June 2016 at 07:25

Issue summary:

View changes

Status	File	Size
new	file_embed_creation.png	26.86 KB

@ron_s, sorry for that, I certainly misunderstood your issue initially.

In any case, I might still be missing something, once the options I have with a vanilla install with the current entity_embed (dev) are not the ones you mention in steps 2 and 3:

So I could not really follow your steps to reproduce the problem. In my installation, I was able to restrict the plugin displays of a "File" entity correctly. Either I need to install something else to have a setup similar to yours or I might be missing some configuration here.. Anyways, let's wait for the maintainers of the module to see this issue, they might have some other ideas on what may be going on.

Comment #5

sgdev commented 28 June 2016 at 09:57

Status	File	Size
new	custom_entity_embed_button_form_7.x-3.x-dev.png	87.48 KB

Thank you for the reply. You are using Drupal 8, and this issue is tagged to 7.x-3.x-dev.

The Entity Type description in your image is "Entity type for which this button is to enabled." This is located in the buildConfigurationForm function in Entity.php.

In Drupal 7, this field description is "The type of entity allowed to be embedded using the button." Also, 7.x-3.x-dev includes both entity type and bundles, while 8.x-1.x-dev does not. See attached.