As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#14 2755039-14.patch2.51 KBharsha012
#13 PareviewLog.png5.83 MBAanal.addweb
#11 remove_file_@1234.patch2.2 KBvakulrai
#9 remove_file_doc-2755039-8.patch2.88 KBghuygens
#6 remove-file-doc-3.patch2.51 KBdan.herrero
#3 remove-file-doc-3.patch2.51 KBSonal.Sangale

Comments

Sonal.Sangale created an issue. See original summary.

Sonal.Sangale’s picture

Sonal.Sangale commented
Assigned: Unassigned » Sonal.Sangale
Sonal.Sangale’s picture

Sonal.Sangale commented
Assigned: Sonal.Sangale » Unassigned
Status: Active » Needs review
StatusFileSize
new remove-file-doc-3.patch2.51 KB

Removing @file doc from all .php files.

Status: Needs review » Needs work

The last submitted patch, 3: remove-file-doc-3.patch, failed testing.

dan.herrero’s picture

dan.herrero commented
Assigned: Unassigned » dan.herrero
dan.herrero’s picture

dan.herrero commented
StatusFileSize
new remove-file-doc-3.patch2.51 KB
dan.herrero’s picture

dan.herrero commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: remove-file-doc-3.patch, failed testing.

ghuygens’s picture

ghuygens commented
Status: Needs work » Needs review
StatusFileSize
new remove_file_doc-2755039-8.patch2.88 KB

Another try

Status: Needs review » Needs work

The last submitted patch, 9: remove_file_doc-2755039-8.patch, failed testing.

vakulrai’s picture

vakulrai commented
StatusFileSize
new remove_file_@1234.patch2.2 KB

Patch applied successfully given by #9 ,but my local instance of drupal is showing WSOD .

vakulrai’s picture

vakulrai commented
Status: Needs work » Needs review
Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Needs work
StatusFileSize
new PareviewLog.png5.83 MB

@vakulrai, Thanks for the patch, You made changes as per the errors are shown in pareview.sh, but the change you is incomplete.
Please review this link & change it accordingly. Mainly you have to remove whole @file block not the single line.

harsha012’s picture

harsha012 commented
Status: Needs work » Needs review
StatusFileSize
new 2755039-14.patch2.51 KB

remove @file block

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community

@harsha012, Thanks for creating the patch for the standard error, It works well. I verified it using pareview.sh & conclude it that your changes are correctly implemented. PFA

renatog’s picture

renatog commented

Hi people.

I applied the patch and really works good.

Thank you very much for your contribution.

  • RenatoG committed 10b9571 on 8.x-3.x authored by harsha012 
    Issue #2755039 by Sonal.Sangale, theflyingman, vakulrai, ghuygens,...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to the dev branch.

Thank you very much.

Best.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.