Note: For guidelines and instructions pages linked below, log in with user name / password: drupal/drupal.

Task for this issue

Copy edit the following topic:

Title: Concept: Uses of Views
Section: Creating Listings with Views
File name: views-concept.txt

Look for:
- Typographical errors
- Spelling errors
- Grammar and usage errors
- Punctuation problems
- Adherence to the project's editing guidelines: https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines-edi... (access: drupal / drupal )
- Adherence to the project's writing guidelines: https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines-wri... (access: drupal / drupal )
- Formatting problems in the output. The User guide output can be found on: https://userguide_new-drupal.dev.devdrupal.org/d8guide/en/index.html (access: drupal / drupal )

Note that the "single-issue" guidelines in the Editing guidelines page, as well as the entire Writing guidelines page, should have already been enforced. But it is still a good idea to at least check them quickly.

Instructions

See https://userguide_new-drupal.dev.devdrupal.org/guidelines/instructions.h... -- but skip the section on finding a task to do, since you have selected this one.

Checklist for this task

- Is a patch file provided? If only one or a few topics were edited, you can instead attach the updated source file(s).
- Is the edit complete and correct?
- Is the work free from additional edits outside the scope of the provided guidelines or task?
- Is attribution provided? See https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines.htm...

CommentFileSizeAuthor
#10 user_guide-views_concept-2754555_10.patch2.23 KBjojyja
#8 user_guide-views_concept_2754555_8.patch1.88 KBjojyja
#6 user_guide-views_concept-2754555-6.patch1.65 KBjojyja

Comments

jhodgdon created an issue. See original summary.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Assigned: Unassigned » swarad07
swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Active » Needs review

Did not find any issues in the file. It is fine the way it is.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Fixed

Thanks @swarad07. Looks good to me as well. Fixed!

jojyja’s picture

jojyja commented
Assigned: swarad07 » jojyja
Status: Fixed » Active
jojyja’s picture

jojyja commented
Status: Active » Needs review
StatusFileSize
new user_guide-views_concept-2754555-6.patch1.65 KB

Here is a patch with minor suggested updates.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Thanks for the patch!

So... I am not sure about these changes. It seems that there is some confusion in the page between "the core Views module" and "views" (the things that the core Views module lets you create and manage). Can you take another look at the page, with that in mind?

And maybe we should talk about "you can create a view to..." or "you can use the core Views module to..." instead of "views let you..." etc. Thoughts?

jojyja’s picture

jojyja commented
Status: Needs work » Needs review
StatusFileSize
new user_guide-views_concept_2754555_8.patch1.88 KB

I agree with your feedback on highlighting core Views module and views separately. Here is the patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Thanks! This is better... but I think really that this topic requires more extensive editing (sorry for not looking closer the last time).

Some thoughts:

  1. +++ b/source/en/views-concept.txt
@@ -14,10 +14,10 @@
 A _view_ is a listing of content on a website. To take some examples from
 the farmers market project, the following listings will be implemented as views:
 
-* The list of all vendors
-* The list of recipes
+* List of vendors
+* List of recipes
 
-Views provide a way to output a listing of content from the system, which can
+The core Views module can be used to output a listing of content from the system, which can
 then be displayed in various ways.

    So...

    That first sentence explains what a "view" is.

    Then this other paragraph seems to be saying the same thing, but saying it's from the core Views module. Maybe they should be consolidated? So the first paragraph could say:

    A _view_ is ..... The core Views module handles the display of views, and the core Views UI module allows you to create and edit them in the administrative interface.

    or something like that.

    I also think that the "can be displayed in various ways" part is redundant with a following section, and then the next sentence/paragraph about "define content entities..." is redundant with a following section too.

    So... this first section probably needs some additional editing and consolidation, down to one simple paragraph. 

  2. +++ b/source/en/views-concept.txt
@@ -26,19 +26,19 @@ data _out_ and displaying it to the user.
 the system. For example, you can create:
 
 * Lists of the most recent content on the site
-* Lists of the users on the site
+* Lists of users on the site

    I wonder if maybe the list of examples from the top section should be moved into and consolidated with this section's list? Please? :) 

  3. +++ b/source/en/views-concept.txt
@@ -26,19 +26,19 @@ data _out_ and displaying it to the user.
+==== What are the various ways data can be output using views?

    Can we lose the word "various" from this heading? 

  4. +++ b/source/en/views-concept.txt
@@ -26,19 +26,19 @@ data _out_ and displaying it to the user.
+A listing created by the core Views module can be in the form of a page containing a table

    Instead of "listing created by the core Views module", why not call it a "view" or "view output"? 

  5. +++ b/source/en/views-concept.txt
@@ -26,19 +26,19 @@ data _out_ and displaying it to the user.
+A listing created by the core Views module can be in the form of a page containing a table
+with sortable fields, or a page with a grid, or a page containing teasers or
 pictures which link to respective articles.
 
-However, _views_ can also provide data in the form of blocks, JSON output, RSS
+You can also create a view to provide data in the form of blocks, JSON output, RSS
 feeds, calendars, on-screen slideshows, and much more.

    Would this section be clearer as a bullet list?

jojyja’s picture

jojyja commented
Status: Needs work » Needs review
StatusFileSize
new user_guide-views_concept-2754555_10.patch2.23 KB

Thanks for the feedback :) Here is the updated patch.

  • jhodgdon committed a15e086 on 8.x-0.x authored by jojyja 
    Issue #2754555 by jojyja: Copy edit views-concept.txt
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Great work! Committed. Thanks!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.