Patch coming shortly

CommentFileSizeAuthor
#9 2754249-Add-four-column-3-3-3-3-7-8.patch1.5 KBdarol100
#8 add_4_column_layouts-2754249-7.patch1.25 KBrealityloop
#6 add_4_column_layouts-2754249-6.patch5.86 KBrealityloop
#5 add_4_column_layouts-2754249-5.patch5.86 KBrealityloop
#4 add_4_column_layouts-2754249-4.patch10.07 KBrealityloop
#2 add_4_column_layouts-2754249-2.patch4.4 KBrealityloop

Comments

realityloop created an issue. See original summary.

realityloop’s picture

realityloop commented
Status: Active » Needs review
StatusFileSize
new add_4_column_layouts-2754249-2.patch4.4 KB
darol100’s picture

darol100 commented
Status: Needs review » Needs work

@realityloop, Great work. By looking at your patch we are missing the template definition at bootstrap_layouts.layouts.yml. In order to have the templates working, we need to have label, category, path, icon, template, regions.

For more information checkout the documentation at - https://www.drupal.org/node/2578731.

realityloop’s picture

realityloop commented
Status: Needs work » Needs review
StatusFileSize
new add_4_column_layouts-2754249-4.patch10.07 KB

@darol100

Just figured that out myself and came here to find your comment :)

Updated patch attached.

realityloop’s picture

realityloop commented
StatusFileSize
new add_4_column_layouts-2754249-5.patch5.86 KB

Oops, you did some work since last patch.. rerolling..

realityloop’s picture

realityloop commented
StatusFileSize
new add_4_column_layouts-2754249-6.patch5.86 KB

linked image was incorrect.

  • darol100 committed a5988b4 on 8.x-3.x authored by realityloop 
    Issue #2754249 by realityloop: Add four column 3-3-3-3 and four column...
realityloop’s picture

realityloop commented
StatusFileSize
new add_4_column_layouts-2754249-7.patch1.25 KB

@darol100

There were still some issues with that last patch..

Here is a reroll that includes just the fix to whats already been committed.

darol100’s picture

darol100 commented
StatusFileSize
new 2754249-Add-four-column-3-3-3-3-7-8.patch1.5 KB

Updating patch....

  • darol100 committed 4e81eb1 on 8.x-3.x authored by realityloop 
    Issue #2754249 by realityloop: Add four column 3-3-3-3 and four column...
darol100’s picture

darol100 commented
Status: Needs review » Fixed

@realityloop Thank you for this patch.

  • darol100 committed a5988b4 on 8.x-4.x authored by realityloop 
    Issue #2754249 by realityloop: Add four column 3-3-3-3 and four column...
  • darol100 committed 4e81eb1 on 8.x-4.x authored by realityloop
    Issue #2754249 by realityloop: Add four column 3-3-3-3 and four column...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.