Note: For guidelines and instructions pages linked below, log in with user name / password: drupal/drupal.

Task for this issue

Copy edit the following topic:

Title: Concept: Themes
Section: Understanding Drupal
File name: understanding-themes.txt

Look for:
- Typographical errors
- Spelling errors
- Grammar and usage errors
- Punctuation problems
- Adherence to the project's editing guidelines: https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines-edi...
- Adherence to the project's writing guidelines: https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines-wri...

Note that the "single-issue" guidelines in the Editing guidelines page, as well as the entire Writing guidelines page, should have already been enforced. But it is still a good idea to at least check them quickly.

Instructions

See https://userguide_new-drupal.dev.devdrupal.org/guidelines/instructions.h... -- but skip the section on finding a task to do, since you have selected this one.

Checklist for this task

- Is a patch file provided? If only one or a few topics were edited, you can instead attach the updated source file(s).
- Is the edit complete and correct?
- Is the work free from additional edits outside the scope of the provided guidelines or task?
- Is attribution provided? See https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines.htm...

CommentFileSizeAuthor
#10 user_guide-understanding_themes-2753033-10.patch983 bytesjojyja
#4 copy_edit-2753033-4.patch1.26 KBswarad07

Comments

jhodgdon created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue summary: View changes
swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Assigned: Unassigned » swarad07
swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Active » Needs review
StatusFileSize
new copy_edit-2753033-4.patch1.26 KB

Written and edited by https://www.drupal.org/u/swarad07[Swarad Mokal] of http://www.blisstering.com[Blisstering Solutions].

Checked for errors as mentioned in issue summary. Please let me know if any changes needed.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks for looking over this topic!

It turns out that the changes in your patch are not quite what we want:

  1. +++ b/source/en/understanding-themes.txt
@@ -2,13 +2,13 @@
-(((Theme,overview)))
-(((Theme,core)))
-(((Core theme,overview)))
-(((Theme,third-party)))
-(((Third-party theme,overview)))
-(((Theme,custom)))
-(((Custom theme,overview)))
+(((Theme, overview)))
+(((Theme, core)))
+(((Core theme, overview)))
+(((Theme, third-party)))
+(((Third-party theme, overview)))
+(((Theme, custom)))
+(((Custom theme, overview)))

    These are AsciiDoc index entries, and according to our standards for them:
    https://userguide_new-drupal.dev.devdrupal.org/guidelines/formatting.htm...

    There should not be spaces after the commas, actually. 

  2. +++ b/source/en/understanding-themes.txt
@@ -31,8 +31,8 @@ Drupal is a well established CMS so the market for 3rd party themes - both free
-theme. A custom theme can be as simple as a single CSS file that adds styling to
-the markup provided by the core software.  Guidance for creating custom themes
+theme. A custom theme can be as simple as a single CSS file that adds styling ¶
+to the markup provided by the core software. Guidance for creating custom themes

    This change seems to be just rewrapping the lines? I don't see any textual changes.

    If so... the wrapping was correct as it was (the lines were 80 characters or less already). And in rewrapping, you left a space at the end of one line, which isn't good.

So... I guess this topic doesn't need any changes, which is great! I'll add your attribution to the "guide-wide copy editing" to make sure you get credit for reading the topic and proofreading. Thanks!

  • jhodgdon committed f8b7e6c on 8.x-0.x 
    Issue #2753033 by jhodgdon: Add copy editing attribution for swarad07
swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented

Thanks jhodgdon for your valuable feedback. I will make sure to read the guidelines thoroughly next time.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jojyja’s picture

jojyja commented
Assigned: swarad07 » jojyja
Status: Closed (fixed) » Active
jojyja’s picture

jojyja commented
Status: Active » Needs review
StatusFileSize
new user_guide-understanding_themes-2753033-10.patch983 bytes

Here is a patch with minor suggested updates.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks for rechecking this! Both edits look good to me.

  • jhodgdon committed fb159b4 on 8.x-0.x authored by jojyja 
    Issue #2753033 by jojyja: Copy edit understanding-themes.txt

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.