The Search pages page contains four sections that relate to the configuration of Search and Indexing (Indexing progress, Indexing throttle, Default indexing settings, and Logging) and one section that contains a list of Search pages with the option to add new such pages.
This is a non-standard set-up because on similar pages for other modules such configuration and list are two separate pages, usually connected to each other as tabs. On these list pages the primary button "Add foo" is located at the top of the page.
This is a usability issues because users will not expect such a list at the bottom of a configuration page, and therefore are likely to overlook that it's possible to add more custom search pages. It also makes it more possible to grant user access to add more search pages, without granting them the permission to change the indexing configuration.
Split the content of the "Search pages" page on into "Search pages" and "Indexing", or "Indexing configuration" or so.
This is a UI change and the hook_help text will need to be edited accordingly.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-2752927-2-6.txt | 5.21 KB | haza |
| #6 | split_search_page_in_a-2752927-6.patch | 21.09 KB | haza |
| #2 | split_search_page_in_a-2752927-2.patch | 16.05 KB | haza |
| #2 | capture_6c6a5ad.png | 25.71 KB | haza |
| #2 | capture_98188ca.png | 33.24 KB | haza |
Comments
Comment #2
hazaHere is a first patch that splits this into 2 pages.
I did not touch anything in tests right now, and hook_help still needs to be updated.
Comment #3
hazaAlso, if #2752915: Rename "Add page" to "Add search page" went in, we'll need to reroll this patch.
Comment #4
ifrikThanks Haza,
that works as I envisioned it. We will need some review by the module maintainer for this as well.
Comment #6
hazaWorking on updating the tests. This should have less failling tests.
Comment #7
ifrikComment #8
yoroy commentedThe general idea proposed here makes a lot of sense. Nice find, it's indeed a non-standard setup to have this list of pages at the bottom of a settings page.
- I think with the pages list on a seperate page we can also remove the collapsible fieldset around it.
- The 'Add new page' button needs to get the button--primary class to make it blue
- The current standard page titles for these kinds of pages are "List" and "Settings" (See: forums, books, feed aggregator). I think it should definately say "List", but for example "admin/config/regional/language" uses "Detection and selection" as the label for the second "Settings" tab. I don't think we should use the "Configuration" word here. Maybe "Indexing" or "Index settings"?
- A different issue most likely, but what is that "Search page type" dropdown even supposed to be doing? I don't see it have any effect when I make a selection
Thanks for working on this!
Comment #9
ifrikThanks yoroy,
there also is a separate issue for just the button, because it looked like an quick novice issue: #2752915: Rename "Add page" to "Add search page".
There the proposal to turn the button into a primary button was rejected.
Comment #11
ifrikComment #25
smustgrave commentedThank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #27
quietone commentedThe Search Module was approved for removal in #3476883: [Policy, no patch] Move Search module to contrib .
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3565780: [meta] Tasks to deprecate the Search module and the removal work in #3565783: [meta] Tasks to remove the Search module.
Search will be moved to a contributed project before Drupal 12.0.0 is released.