VideoDetectorCKEditorButton.php
line 37-41
$path = '/libraries/videodetector';
return array(
'VideoDetector' => array(
'label' => t('Video detector ckeditor button'),
'image' => $path . '/icons/videodetector.svg',
replace by
return array(
'VideoDetector' => array(
'label' => t('Video detector ckeditor button'),
'image' => base_path().'libraries/videodetector/icons/videodetector.svg',
line 52-53
$path = '/libraries/videodetector';
return $path . '/plugin.js';
replace by
return base_path().'libraries/videodetector/plugin.js';
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | correct_libraries_paths-2752657-6.patch | 1.5 KB | aoturoa |
| #5 | correct_libraries_paths-2752657-5.patch | 1.34 KB | aoturoa |
| #3 | correct_libraries_paths-2752657-3.patch | 1.78 KB | awasson |
Comments
Comment #2
JFH - 3DX internet commentedComment #3
awasson commented@JFH is correct. I have trested those changes and they do indeed work as described. I've attached a patch for your module.
Cheers,
Andrew
Comment #4
awasson commentedThinking a little more on this. Perhaps a ckeditor_videodetector.libraries.yml file would be ideal for this module?
I will investigate and post back.
Andrew
Comment #5
aoturoa commentedI like the ckeditor_videodetector.libraries.yml approach.
Furtermore using 'base_path()' isn't optimal, better is using 'libraries_get_path()' once a dependency on libraries is added.
Comment #6
aoturoa commentedThe following patch applies to current 8.x-1.0 release.
Comment #7
awasson commentedYes, I think that is a much better approach and more in line with the OOP/MVC approach taken in D8.
Comment #8
darol100 commentedThe libraries module in D8 is not does not have a stable version nor have a clear direction future of that project. For this reason, I do not think is smart idea to added as dependency. This issue is related to #2758579: Best way for getFile to retrieve file(s) from the /libraries directory?, which is been solve in this commit.