Problem/Motivation

The "Filter" button on the on the URL alias page is marked as a primary button (displayed in blue in Bartik). This is inconsistent with the mark-up of filter buttons on other pages such as the Content page, and also defeats the purpose of separating primary call-to-actions (in this case Add alias) from others.

Proposed resolution

Turn the link into a normal button instead of a primary button by changing the CSS class.

Remaining tasks

Turn the link into a normal button instead of a primary button by changing the CSS class.

User interface changes

This is a UI change that improves usability by providing consistency and visual hierarchy.

API changes

Data model changes

CommentFileSizeAuthor
#7 2752149-7.patch516 bytespashupathi nath gajawada
#3 screenshot-d8-2 nightingale 2016-06-21 11-17-02.png15.38 KBifrik
#2 remove-primary-class-from-filter-button-2752149-2.patch516 bytesmarcoscano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano as a volunteer commented
Status: Active » Needs review
FileSize
remove-primary-class-from-filter-button-2752149-2.patch516 bytes

Is it ok just to remove the #button_type property?

-      '#button_type' => 'primary',
ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +sprint
FileSize
screenshot-d8-2 nightingale 2016-06-21 11-17-02.png15.38 KB

Thanks marcoscano,

removing the button_type property works as required and the "Filter" button is now displayed as a normal (grey) button.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary commented

Looks great! As an erstwhile admin module maintainer this was always a thorn in my side.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: remove-primary-class-from-filter-button-2752149-2.patch, failed testing.

pguillard’s picture

pguillard CreditAttribution: pguillard commented

Re-testing cause I guess the bot got crazy

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Status: Needs work » Needs review
FileSize
2752149-7.patch516 bytes

Uploading the same patch,
As to find why the tests failed.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs review » Reviewed & tested by the community

pashupathi nath gajawada,

Please do not rename existing patches. This is really disrespectful to the person who did the actual work.

As you can see, pguillard simply send his patch for testing again, and it passed.

Setting this to RTBC again because the original patch is #2 passed and was already RTBC'ed.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Related issues: +#2166473: [meta] Ensure correct button types are used on all pages
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 440b828 and pushed to 8.2.x. Thanks!

@pashupathi nath gajawada I didn't credit you because the patch didn't need a reroll and retesting doesn't require another patch.

  • alexpott committed 440b828 on 8.2.x 
    Issue #2752149 by marcoscano, ifrik: "filter" button should be normal (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -sprint

Thanks, removing from UX sprint now.