As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#7 2751221-7.patch64.25 KBrajeshwari10
#5 2751221-5.patch61.31 KBrajeshwari10
#3 2751221-2.patch64.06 KBrajeshwari10

Comments

rajeshwari10 created an issue. See original summary.

rajeshwari10’s picture

rajeshwari10 commented
Assigned: Unassigned » rajeshwari10
rajeshwari10’s picture

rajeshwari10 commented
Status: Active » Needs review
StatusFileSize
new 2751221-2.patch64.06 KB

Added patch

Status: Needs review » Needs work

The last submitted patch, 3: 2751221-2.patch, failed testing.

rajeshwari10’s picture

rajeshwari10 commented
Status: Needs work » Needs review
StatusFileSize
new 2751221-5.patch61.31 KB
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

If we commit this cleanup, we want to do a uniform cleanup for the header.

After applying this patch, sometimes we have two, sometimes one line break prior to the first namespace line.

rajeshwari10’s picture

rajeshwari10 commented
Status: Needs work » Needs review
StatusFileSize
new 2751221-7.patch64.25 KB

Adding one line break prior to the first namespace line.

Please review.

Thanks!!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, committed.

  • Berdir committed a6c2fb6 on 8.x-1.x authored by rajeshwari10 
    Issue #2751221 by rajeshwari10: Remove @file tag docblock from all the ....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.