The 8.x version of AMP Metadata allows the option to select image styles for AMP Metadata. Would be nice to have that option in 7.x as well.

CommentFileSizeAuthor
#3 2751185-3-interdiff.txt650 bytesmtift
#3 2751185-3.patch7.06 KBmtift
#2 2751185-2.patch7.06 KBRainbowArray
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mdrummond created an issue. See original summary.

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray at Lullabot commented
Status: Active » Needs review
FileSize
2751185-2.patch7.06 KB

This adds default image styles, image style configuration options for AMP Metadata, as well as optional usage of image styles in JSON generation.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs review » Needs work
FileSize
2751185-3.patch7.06 KB
2751185-3-interdiff.txt650 bytes

The image style overrides still do not seem to be working, but the I got the global settings to work with the attached patch.

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray at Lullabot commented

The content type image styles appear to be working for me. Reviewed and debugged the code, don't see an issue. Not sure why this wouldn't be working.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Fixed

The patch in #3 is working. We discovered an unrelated issue, so committing this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.