"email.validator" core service cannot be easily replaced

Why do you need an alternative implementation in the first place? Aren't emails a standard so one reference implementation should be enough? I'm just trying to be curious here.

The alternative way would be to add an interface upstream, any reason that we have to do that in Drupal itself?

Why is this Major?

The e-mail validator service does not only check syntax but also that the domain exists.

No, it does not. DNS check is false by default.

This may help https://github.com/egulias/EmailValidator/pull/119

#2755401: Upgrade EmailValidator to 2.x

The EmailValidator 2.x interface breaks existing implementations which is a +1 for this issue.

Also interesting is that Symfony maintains its own interface in the form of Symfony\Component\Validator\Constraints\EmailValidator (part of its family of validators), which Drupal uses in some situations and the email.validator service in others.

@david_garcia There is a question on github about a new interface in version 2.

I postponed #2755401: Upgrade EmailValidator to 2.x on this.

This should match the current core service.

We are going to need something like this as a BC layer to move to 2.x of EmailValidator.

1. +++ b/core/lib/Drupal/Component/Utility/EmailValidator.php
   @@ -0,0 +1,36 @@
   +/**
   + * Validates email addresses.
   + */
   +class EmailValidator implements EmailValidatorInterface {
   

   What about using "Valides email addresses using the egulias\EmailValidator" library or something like that?

2. +++ b/core/lib/Drupal/Component/Utility/EmailValidator.php
   @@ -0,0 +1,36 @@
   +   * @var EmailValidator
   ...
   +   * @param EmailValidatorUtility $emailValidator
   

   Let's use the FQCN

3. +++ b/core/lib/Drupal/Component/Utility/EmailValidatorInterface.php
   @@ -0,0 +1,24 @@
   +/**
   + *
   + */
   

   Nitpick: Let's kill that, it is not longer needed.

Patch re-rolled.

Thanks great work!

1. +++ b/core/lib/Drupal/Component/Utility/EmailValidatorInterface.php
   @@ -0,0 +1,24 @@
   +/**
   + *
   + */
   

   What this is for ? if not needed. remove it.

2. +++ b/core/lib/Drupal/Component/Utility/EmailValidatorInterface.php
   @@ -0,0 +1,24 @@
   +   * Verifies the validity of the given email address.
   

   "Validates an email address."

Updating patch as it was not getting applied to recent 8.3.x branch.
Fixing suggestions mentioned by @naveenvalecha

There are some random failures in ArgumentPlaceholderUpdatePathTest, which doesn't seems relevant to this patch.
Any help or suggestions are appreciated.

Straight re-roll of previous patch.

Thanks!

The patch looks OK to me, but it needs a change record.

Added draft CR https://www.drupal.org/node/2886353 .however, I felt that it needs more finishing before gets published. Back to RTBC.

//Naveen

Won't this break now if anyone typehints the validator via the class? I fear what you want to do is this instead:

class EmailValidator extends OldEmailValidator implements EmailValidatorInterface {
}

I think @dawehner is right, moving back to needs work.

Also think about #2755401: Upgrade EmailValidator to 2.x.

@cilefen,
The current issue will open the way for #2755401: Upgrade EmailValidator to 2.x once the current issue will lands.

Assigned to me for #33
Question:
Do we require any empty hook_update_n or hook_post_update_name as we're adding a new service here?

//Naveen

Will it? If memory serves, emailvalidator has a new interface.

Attached two patches:

2749873-38.patch: This accommodated #33. As we're extending the OldEmailValidator so we don't need the isvalid function in the new service now, we could use the existing one.

2749873-38-2.patch: 2749873-38.patch + It includes an empty hook_update_n to ensure the container is actually rebuild.

Edit:
#37, Not sure about it, However, added two patches one with empty hook_update_n and other without it.
//Naveen

+++ b/core/lib/Drupal/Component/Utility/EmailValidator.php
@@ -0,0 +1,29 @@
+   *
+   * @param EmailValidatorUtility $emailValidator
+   *   The email validator utility.
+   */
+  public function __construct(EmailValidatorUtility $emailValidator) {
+    $this->emailValidator = $emailValidator;
+  }

You miss the call to parent::__construct()

Whatever we do here must be compatible with upgrading the library. And I'm not sure it's possible in a simple way. We may be forced to deprecate the current service and introduce a new one.

#41,
Addressed.

#42,
you are right Chris, it does not look that we could upgrade without the BC break. I have updated the patch there with the interdiff from 2749873-43-2.patch

//Naveen

I suggest we close this in favor of #2755401: Upgrade EmailValidator to 2.x.

@cilefen I agree... I'll add the people who worked on this to the credits on the other issue.