When going to the translation tabs on nodes, I am seeing this error:

Notice: Trying to get property of non-object in locale_language_url_rewrite_url() ....

There is a l() function in entity_translation.admin.inc which is passing across a language as a string rather than an object. This is legacy from D6, and needs to be fixed.

CommentFileSizeAuthor
#2 entity_translation-link-language-error-2749525-2.patch1.23 KBchrisdarke

Comments

ChrisDarke created an issue. See original summary.

chrisdarke’s picture

chrisdarke commented
StatusFileSize
new entity_translation-link-language-error-2749525-2.patch1.23 KB

Very simple fix, just changing $langcode to $language, to pass across the object as is appropriate

chrisdarke’s picture

chrisdarke commented
Version: 7.x-1.0-beta4 » 7.x-1.0-beta5
rudi teschner’s picture

rudi teschner commented

Thanks, this fixed the notice for me too. :)

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Status: Active » Needs review
Related issues: +#2444203: Show fallback information on the translation overview

Picking this up for review

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Version: 7.x-1.0-beta5 » 7.x-1.x-dev

Ok, this does look very clean. However, I would still like to reproduce the behaviour.

@Rudi Teschner: Could you provide a couple of steps to reproduce the problem?

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Status: Needs review » Reviewed & tested by the community

All right, I was able to get the notice, by forcing the second part of the ternary condition.
This is ready to go in.

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the helping hand everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.