The error message shown when the Redis server isn't connected properly is currently very broken and confusing English:

"No Redis client connected, this module is useless thereof. Ensure that you enabled module using it or disable it."

The attached patch converts it to an English sentence.

CommentFileSizeAuthor
redis-error-message.patch649 bytesCrell

Comments

Crell created an issue. See original summary.

pounard’s picture

pounard
Primary language French
commented

Indeed, thanks :) It seems weird you ever saw it in the end, I usually don't advise to enable the module in the first place but directly use the cache backend with a correct settings.php configuration. I will apply your patch, thanks.

Crell’s picture

Crell commented

Of note: I also noticed the same issue in the new 8.x alpha branch. It should get applied there, too.

I suspect it was added originally by a non-english speaker, and because the module is rarely enabled no one saw it. I spotted it while doing testing of Redis support for Platform.sh, for which I did want the module enabled for... exactly that error message to confirm if what I was doing worked correctly. :-)

Should this be RTBCed then?

pounard’s picture

pounard
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

Yes I am the non-english speaker, thank you for the reminder :)

  • Pierre.R committed 539f2f3 on 7.x-3.x authored by Crell 
    Issue #2748695 by Crell: Error message is an English parse error

pounard credited Pierre.R.

pounard’s picture

pounard
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

It's been a long time this was waiting for a commit, thanks, and sorry for the delay :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.