Hi!

I detected a bug: an error message is shown at all pages that contain ampersand ("&") in path. For example, pages of Batch operations, pages of Webform components are affected. See my screenshot.

CommentFileSizeAuthor
#2 google_analytics_reports_check_plain-2748533-1.patch1.47 KBchalk
2016-06-14_1806.png203.32 KBchalk

Comments

Chalk created an issue. See original summary.

chalk’s picture

chalk commented
Status: Active » Needs review
StatusFileSize
new google_analytics_reports_check_plain-2748533-1.patch1.47 KB

As I understand this bug is a result of incorrect using check_plain() function. The function should be removed from views argument plugin, because it converts '&' to '&' and then this string are sent to Google API. For example, a path "/node?a=1&b=2" is converted to "/node?a=1&b=2".

Also I added check_plain() wrapper to Google's error response.

If you want to reproduce this bug - just add at least 2 get parameters connected by '&' to any Drupal path.

  • Plazik committed 152f79c on 7.x-3.x authored by Chalk 
    Issue #2748533 by Chalk: Invalid value 'ga:pagePath' for URLs with...
plazik’s picture

plazik commented
Status: Needs review » Fixed

Thank you for the patch.
Commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.