This bug relates to a menu that has "Advanced->Add cloned parent links to the top of sub-menus" enabled. In this case, the superfish module is doing the "parent clone".

Both sf-Smallscreen and sf-Touchscreen plug-ins can also do "parent clone!" That's different and it works fine.

When the module is doing "parent clone", it sets the CSS classes incorrectly.

  • sf-clone-parent is added to the items following a parent clone, rather than just the cloned item.
  • last is added to the penultimate item rather than the last.
CommentFileSizeAuthor
#2 superfish.parent_clone.2747997-2.patch2.05 KBAdamPS
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AdamPS created an issue. See original summary.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Active » Needs review
FileSize
superfish.parent_clone.2747997-2.patch2.05 KB

Here is a patch for review please.

The patch includes a test ['page_callback'] != 'drupal_not_found'. This is an extra change to make superfish work with menu items created by Special menu items module. With this change, the menu is not cloned.

jmoruzi’s picture

jmoruzi
Location Brantford, ON
CreditAttribution: jmoruzi commented

Works for me, thanks.

  • mehrpadin committed 187b826 on 7.x-1.x authored by AdamPS 
    Issue #2747997 by AdamPS: Incorrect classes with "Add cloned parent...
mehrpadin’s picture

mehrpadin CreditAttribution: mehrpadin commented
Status: Needs review » Fixed

Hey,

Thanks, please check.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented

Great many thanks