As per the revised coding standards @file docblock has no use anymore.

We still need @file in .module and .install files, as well as theme templates.
The only @file doc blocks to remove would be for files under (modulename)/src -- the PSR-4-compliant class/interface files.

CommentFileSizeAuthor
#2 2746497-removing-file-docblock-2.patch1.18 KBashhishhh

Comments

ashhishhh created an issue. See original summary.

ashhishhh’s picture

ashhishhh commented
StatusFileSize
new 2746497-removing-file-docblock-2.patch1.18 KB

I removed @file docblock from following files:
src/EasyBreadcrumbBuilder.php
src/EventSubscriber/InitSubscriber.php
src/Form/EasyBreadcrumbGeneralSettingsForm.php

Patch is provided here.

ashhishhh’s picture

ashhishhh commented
Status: Active » Needs review
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Thanks for our first patch to the D8 release of Easy Breadcrumb. I am committing this patch now, and it will be in my next release of Easy Breadcrumb.

  • Greg Boggs committed 8cd4fad on 8.x-1.x authored by ashhishhh 
    Issue #2746497 by ashhishhh: Unnecessary @file doc block in module code
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Fixed
chrischee18’s picture

chrischee18 commented

Hi.

I'm not sure if this is the correct place to post this but I seem to be having a problem with Easy Breadcrumbs.

It is not appearing in my list of available blocks in Drupal 8.

Thanks,
Chris.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Hi Chris,

Thanks for asking! Sorry for the confusion. With Drupal 8, the core breadcrumbs are extended. So, there is only 1 breadcrumb block labeled "system" in the block UI. The block that's enabled in Bartik by default will be updated by easy breadcrumb. So, unlike Drupal 7, there's no duplicate block required.
~Greg

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.