Closed (fixed)
Project:
Akamai
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
7 Jun 2016 at 16:39 UTC
Updated:
30 Mar 2018 at 18:19 UTC
Jump to comment: Most recent, Most recent file
This feature is in 7.x so it should be available in 8.x-3.x It's also Akamai's recommended pattern for specifying creds.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | akamai--2744253--support-edgerc--10.patch | 10.67 KB | WidgetsBurritos |
Comments
Comment #2
jtsnow commentedNote that the 7.x-3.x branch does not currently allow uploading a .edgerc file, but it does allow specifying the path to the .edgerc file on the server.
Comment #3
WidgetsBurritos commentedAs I need this functionality, I'm currently working on an initial patch for this issue.
Comment #4
WidgetsBurritos commentedHere's my initial attempt at the patch. One notable difference between the D7 and D8 version here is that the form I didn't port any of the
#element_validatefunctions.Mainly, I just wanted to make sure everyone is okay with this approach first.
Comment #5
WidgetsBurritos commentedI went ahead and ran the tests. For clarification, those 4 test failures are already occurring on the main branch, so they aren't the result of this patch.
Comment #6
WidgetsBurritos commentedComment #7
WidgetsBurritos commentedIt's worth noting the unit tests I wrote didn't get ran above. There is a separate issue with unit tests that needs to be resolved first: #2950260: Unit tests aren't running
Comment #8
bighappyface commented+1 for #4
Comment #9
WidgetsBurritos commentedNow that #2950260: Unit tests aren't running has been merged, this needs to be rerolled. I'm working on it now.
Comment #10
WidgetsBurritos commentedRerolled. We should now see the unit test results included in the Drupal CI run.
Comment #11
WidgetsBurritos commentedComment #12
WidgetsBurritos commentedAck... That was supposed to go in the comment, not the summary. Let's try that again.
Okay I can confirm that we see

testSetupEdgeRcrunning and passing now. The others are still failing, but that's another issue for another day.Comment #13
bighappyface commented+1 for #10
Comment #15
WidgetsBurritos commentedI've gone ahead and merged this functionality in. In regards to my comment in #4 above, it doesn't appear we have validation for any other fields either, so I've created a separate issue for evaluated form validation on the module as a whole: #2950847: Form validation and marking this issue as fixed.
Comment #16
WidgetsBurritos commented