Currently

Initiating masquerade: "User DestinationUser masqueraded as DestinationUser."
Terminating masquerade: "User SourceUser stopped masquerading as SourceUser."

Must be

Initiating masquerade: "User SourceUser masqueraded as DestinationUser."
Terminating masquerade: "User SourceUser stopped masquerading as DestinationUser."

Problem

Variable $account is changed by ...->setAccount();

$account = $this->currentUser;
...
$this->currentUser->setAccount($new_user);
...
$this->logger->info(..., $account->getDisplayName() );

Solution

- $account = $this->currentUser;
+ $account = $this->currentUser->getAccount();
CommentFileSizeAuthor
#2 masquerade-2743333-fix-watchdog-begin-end-messages.patch866 bytesragnarkurm

Comments

ragnarkurm created an issue. See original summary.

ragnarkurm’s picture

ragnarkurm commented
StatusFileSize
new masquerade-2743333-fix-watchdog-begin-end-messages.patch866 bytes
ragnarkurm’s picture

ragnarkurm commented
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
hgoto’s picture

hgoto commented
Status: Needs review » Reviewed & tested by the community

I tested the patch #2 and I confirmed it fixes the issue. It's simple and I'd like to move this to RTBC.

The following is off-topic. How about changing the variable name for more code readability? For example, in the method switchTo(), the variable $account means the original account that going to masquerade another user. So $original_account is more easy-to-understand name than account, I think. But this may be against the policy or something. I'd like to hear other opinion.

  • andypost committed 416682a on 8.x-2.x authored by ragnarkurm 
    Issue #2743333 by ragnarkurm: Invalid message on initiating and...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Thanx, commited and pushed!

@hgoto Please file new issue, I think $target_account is nicely describes the target of the function but probably better to extend code comments and change local variable names - suggestions are welcome in separate issue)

hgoto’s picture

hgoto commented

@andypost, thank you for your reaction. I see. I understood! I'll file a new issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.