API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

Doxygen states the method is expecting a variable named $cache_backend, when it is actually expecting a variable named $cache.

CommentFileSizeAuthor
#2 doxygen_typo_for_cache-2742211-2.patch785 bytesjsdix

Comments

jsdix created an issue. See original summary.

jsdix’s picture

jsdix commented
Assigned: jsdix » Unassigned
Status: Active » Needs review
StatusFileSize
new doxygen_typo_for_cache-2742211-2.patch785 bytes
jsdix’s picture

jsdix commented
traviscarden’s picture

traviscarden commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks, @jsdix!

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Priority: Normal » Minor
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This is the only instance of an incorrect param in the file. Committed 2bb1b8d and pushed to 8.1.x and 8.2.x. Thanks!

Given that this is @jsdix's first commit - I've committed this patch - however we should be looking to enable the coder rule that checks this so all of core is compliant. See core/phpcs.xml.dist and the coder project.

  • alexpott committed 671a41e on 8.2.x 
    Issue #2742211 by jsdix: Doxygen typo for $cache variable

  • alexpott committed 2bb1b8d on 8.1.x 
    Issue #2742211 by jsdix: Doxygen typo for $cache variable

(cherry...

Status: Fixed » Needs work

The last submitted patch, 2: doxygen_typo_for_cache-2742211-2.patch, failed testing.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.