Currently, the warning message before logout reads "Your session is about to expire. Do you want to reset it?"

A better wording might be "We are about to log you out for inactivity. If we do, you will lose any unsaved work. Do you want more time?

Comments

Charles Belov created an issue. See original summary.

charles belov’s picture

Issue summary: View changes
chishah92’s picture

Assigned: Unassigned » chishah92
chishah92’s picture

Status: Active » Needs review
StatusFileSize
new1.41 KB

Added a patch to change the suggested text for warning messages.

Thanks!
~Chirag

charles belov’s picture

Thank you. I just tried the patch on simplytest.me and it works.

Is my test sufficient to set it to Reviewed and tested by the community, or does someone else need to test it as well?

mayurjadhav’s picture

Status: Needs review » Needs work

Changes make sense, but I think instead of "Do you want more time" we can keep "Do you want to reset it?" as it is.

"We are about to log you out for inactivity. If we do, you will lose any unsaved work. Do you want more time?"

Change to

"We are about to log you out for inactivity. If we do, you will lose any unsaved work. Do you want to reset it?"

else looks RTBC for me.

jalpesh’s picture

Status: Needs work » Needs review
StatusFileSize
new1.42 KB

Here we go with new warning message.

chishah92’s picture

Added a new patch with changes as per suggested by @Mayur along with interdiff . Please Review and RTBC.

Thanks!
Chirag

chishah92’s picture

mayurjadhav’s picture

Status: Needs review » Reviewed & tested by the community

@chishah92 thanks for the patch and interdiff, looks perfect for me now, marking as RTBC.
Would like to know @Charles Belov's thought on this.

@jalpesh you can't get credits from someone else plate without doing hard work, this shows poor development skills.
if the issue is assigned to someone else then we have to wait at least for 24 hours.

Thanks.

jalpesh’s picture

@mayurjadhav I am not working here for credit. if you look at the patch it is 4 day old.

Thanks for your suggestion.

mayurjadhav’s picture

@jalpesh, Yes I can see chishah92's last patch was 4 days before and it was in Needs Review state and what I suggested to him was 2 hours old. and I was expecting patch from him within 24 hours, which he did.

Thanks.

charles belov’s picture

I'm sorry, but "Do you want to reset it?" seem jargony to me. Reset what?

The WCAG 2.0 writeup on extending time limits contains the following example:

A Web site uses a client side time limit to help protect users who may step away from their computer. After a period of inactivity the Web page asks if the user needs more time. If it doesn't get a response – it times out.

"Do you need more time?" is unambiguous in meaning in a way that "reset" isn't, and is consistent with the WCAG 2.0 wording.

charles belov’s picture

Status: Reviewed & tested by the community » Needs review

Changing to needs review based on my prior comment.

chishah92’s picture

Have changed to "Do you need more time?"

Thanks!
~Chirag

charles belov’s picture

Tested as working on simplytest.me. Does anyone else need to test?

mayurjadhav’s picture

Status: Needs review » Reviewed & tested by the community

Looks perfect, Marking as RTBC,

damienmckenna’s picture

Assigned: chishah92 » Unassigned

Thanks for the patch.

FYI you should leave the "assigned" field set to "unassigned" after you upload a patch - it's for indicating that you're actively working on the issue, not for indicating that you are a person who worked on it.

  • boshtian committed c62df20 on 7.x-4.x authored by chishah92
    Issue #2739114 by chishah92, Charles Belov, mayurjadhav: Change warning...
boshtian’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ressa’s picture

Thanks everyone for improving the wording, it is more easily understandable now. I ported the patch for Drupal 10 in #3390606: Make Drupal 10 warning message more user friendly.