Currently, the warning message before logout reads "Your session is about to expire. Do you want to reset it?"
A better wording might be "We are about to log you out for inactivity. If we do, you will lose any unsaved work. Do you want more time?
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | interdiff-2739114-8-15.txt | 1.52 KB | chishah92 |
| #15 | change-warning-message-2739114-15.patch | 1.41 KB | chishah92 |
| #8 | interdiff-2739114-4-8.txt | 1.52 KB | chishah92 |
| #8 | change-warning-message-2739114-8.patch | 1.42 KB | chishah92 |
| #7 | change-warning-message_2739114_5.patch | 1.42 KB | jalpesh |
Comments
Comment #2
charles belovComment #3
chishah92 commentedComment #4
chishah92 commentedAdded a patch to change the suggested text for warning messages.
Thanks!
~Chirag
Comment #5
charles belovThank you. I just tried the patch on simplytest.me and it works.
Is my test sufficient to set it to Reviewed and tested by the community, or does someone else need to test it as well?
Comment #6
mayurjadhav commentedChanges make sense, but I think instead of "Do you want more time" we can keep "Do you want to reset it?" as it is.
"We are about to log you out for inactivity. If we do, you will lose any unsaved work. Do you want more time?"
Change to
"We are about to log you out for inactivity. If we do, you will lose any unsaved work. Do you want to reset it?"
else looks RTBC for me.
Comment #7
jalpesh commentedHere we go with new warning message.
Comment #8
chishah92 commentedAdded a new patch with changes as per suggested by @Mayur along with interdiff . Please Review and RTBC.
Thanks!
Chirag
Comment #9
chishah92 commentedComment #10
mayurjadhav commented@chishah92 thanks for the patch and interdiff, looks perfect for me now, marking as RTBC.
Would like to know @Charles Belov's thought on this.
@jalpesh you can't get credits from someone else plate without doing hard work, this shows poor development skills.
if the issue is assigned to someone else then we have to wait at least for 24 hours.
Thanks.
Comment #11
jalpesh commented@mayurjadhav I am not working here for credit. if you look at the patch it is 4 day old.
Thanks for your suggestion.
Comment #12
mayurjadhav commented@jalpesh, Yes I can see chishah92's last patch was 4 days before and it was in Needs Review state and what I suggested to him was 2 hours old. and I was expecting patch from him within 24 hours, which he did.
Thanks.
Comment #13
charles belovI'm sorry, but "Do you want to reset it?" seem jargony to me. Reset what?
The WCAG 2.0 writeup on extending time limits contains the following example:
"Do you need more time?" is unambiguous in meaning in a way that "reset" isn't, and is consistent with the WCAG 2.0 wording.
Comment #14
charles belovChanging to needs review based on my prior comment.
Comment #15
chishah92 commentedHave changed to "Do you need more time?"
Thanks!
~Chirag
Comment #16
charles belovTested as working on simplytest.me. Does anyone else need to test?
Comment #17
mayurjadhav commentedLooks perfect, Marking as RTBC,
Comment #18
damienmckennaThanks for the patch.
FYI you should leave the "assigned" field set to "unassigned" after you upload a patch - it's for indicating that you're actively working on the issue, not for indicating that you are a person who worked on it.
Comment #20
boshtian commentedComment #22
ressaThanks everyone for improving the wording, it is more easily understandable now. I ported the patch for Drupal 10 in #3390606: Make Drupal 10 warning message more user friendly.