Problem/Motivation

Moving the Iron.io PHP classes out this module and adding support for Libraries in #2154303: Implement Libraries Support was a nice move. However, attempting to use the current PHP classes causes the following error:

PHP Fatal error:  Class 'IronCore\IronCore' not found in ...sites/all/libraries/ironio_queue/IronMQ.class.php on line 19

This stems from the fact that ironio_libraries_info() includes the "lines" key and its value is just low enough that Libraries misses the version declaration in IronMQ.class.php.

Proposed resolution

This can happily be fixed by tweaking the number of lines to parse when looking for the version (or simply using the default value).

Remaining tasks

Patch. Test.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 ironio-hook_libraries_info_line_increase-2739065-2.patch810 bytesndewhurst

Comments

ndewhurst created an issue. See original summary.

ndewhurst’s picture

ndewhurst
he/him
Primary language English
Location USA
commented
Status: Needs work » Needs review
StatusFileSize
new ironio-hook_libraries_info_line_increase-2739065-2.patch810 bytes

Here's a patch with the simple change mentioned above. The version declaration is currently on line 11. May as well look at 14 lines just for good measure, while avoiding the deadly performance impact of looking at another 6 after that :)

donutdan4114’s picture

donutdan4114 commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.