I want to receive webmentions, but not send them.
So on my nodes I have the Send ref-backs box unchecked and the Receive ref-backs checked.
With these settings, however, a webmention from a third party source receives a Invalid target parameter. error in return.
The vinculum_webmention_validate_resource_accepts_webmentions() function, which is checked inside vinculum_webmention_receive() to see whether a node is set to receive webmentions appears to incorrectly check for whether the node should send webmentions:
/**
* Validate if a resource accepts Webmentions.
*
* @param $node
*
* @return bool
*/
function vinculum_webmention_validate_resource_accepts_webmentions($node) {
if (!$node) {
return FALSE;
}
return (bool) $node->vinculum_send;
}
I think this should be changed to:
/**
* Validate if a resource accepts Webmentions.
*
* @param $node
*
* @return bool
*/
function vinculum_webmention_validate_resource_accepts_webmentions($node) {
if (!$node) {
return FALSE;
}
return (bool) $node->vinculum_receive;
}
When I change this I am then able to uncheck the Send ref-backs box for a node and leave the Receive ref-backs box checked and the node is able to properly receive webmentions, but won't (properly) send them.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2736133-checking-send-should-check-receive.patch | 569 bytes | reinvented |
Comments
Comment #2
reinvented commented