Problem/Motivation

When ERR is empty widget does not display field name in a standard way. This can cause confusion as paragraphs field visually appears to be part of the field above.

Proposed resolution

Display field name.

CommentFileSizeAuthor
#2 Izbor_022.png46.96 KBslashrsm
#2 Izbor_021.png44.37 KBslashrsm
#2 2734957_TEST_ONLY.patch1.13 KBslashrsm
#2 2734957.patch2.95 KBslashrsm

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
StatusFileSize
new 2734957.patch2.95 KB
new 2734957_TEST_ONLY.patch1.13 KB
new Izbor_021.png44.37 KB
new Izbor_022.png46.96 KB

Adds a field name. Other fields usually use tag, but I don't think that it makes sense here as we have no element to refer it to. Made it visually similar, but that might be problematic for themes other than Seven. Not sure which approach would be the best here.

Before:

After:

Status: Needs review » Needs work

The last submitted patch, 2: 2734957_TEST_ONLY.patch, failed testing.

The last submitted patch, 2: 2734957_TEST_ONLY.patch, failed testing.

The last submitted patch, 2: 2734957_TEST_ONLY.patch, failed testing.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

Yay, looks nice, but shouldn't it be a label tag IMHO?

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Issue tags: +Usability
Related issues: +#2668712: Confusing styling and labelling of empty paragraphs fields

This is a duplicate of #2668712: Confusing styling and labelling of empty paragraphs fields, which has some background history, but this has a patch so closing that one.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue tags: +Accessibility

Note that the related issue shows that this was before a label tag.

The label tag is supposed to be related to a form element as of the HTML specification. Not sure thought if using label here is still valid - or if we should relate it to the "Add" button?

It seems to me, we need to follow the ARIA annotations to properly follow the HTML specs.

Accessibility experts, please review the situation. :-)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: Field name is not displayed in a standard way when field is empty » Accessibility: Readd label for the empty paragraph field

Committed: Some label is better than no label. :-)

Still back to needs work for accessibility review / improvement, see #9.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: Accessibility: Readd label for the empty paragraph field » Readd label for the empty paragraph field
Status: Needs work » Fixed
Issue tags: -Accessibility

Created follow-up for the accessibility part. #2736461: [META] Review Paragraphs widget accessibility
Made it more generic for a full review with listing the known issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.