I've found this error on taxonomy/term/% pages after disabling node listing on it using Disable Term Node Listings module.

But i think it isn't caused by Disable Term Node Listings module because it's only alter the menu return content.

So i did quick fix in i18n_taxonomy.module line 461, function i18n_taxonomy_term_name.
This works fine for my current project.

I think if i18n_taxonomy_term_name works the same functioning, this i18n_taxonomy_term_description function may also need to be fix.

Check out the screenshots
Original code
original
Quick fix
fix

Please update the module with proper fixes.
Thanks.

CommentFileSizeAuthor
#14 notice-trying-to-get-property-of-non-object-2733095-14.patch893 bytesrajiv.singh
#10 notice-trying-to-get-property-of-non-object-2733095-10.patch988 bytesjoseph.olstad
#8 notice-trying-to-get-property-of-non-object-2733095-8.patch892 bytesjoseph.olstad
#4 notice-trying-to-get-property-of-non-object-2733095.patch1.05 KBkapil.ropalekar
quickfix.png13.43 KBthihathit
original.png12.05 KBthihathit

Comments

thiha.c created an issue. See original summary.

thihathit’s picture

thihathit commented
Issue summary: View changes
thihathit’s picture

thihathit commented
Issue summary: View changes
kapil.ropalekar’s picture

kapil.ropalekar commented
Version: 7.x-1.13 » 7.x-1.x-dev
Assigned: Unassigned » kapil.ropalekar
Status: Active » Needs review
StatusFileSize
new notice-trying-to-get-property-of-non-object-2733095.patch1.05 KB

Hi thiha.c,

Yes i can confirm that these warnings do appear while using the Disable Term Node Listings module along with Internationalization.

I have verified and created a patch to fix this issue as per your suggested changes. Warnings also appearing on 1.x-1.x-dev thus updating version.

Thanks !

kapil.ropalekar’s picture

kapil.ropalekar commented
Assigned: kapil.ropalekar » Unassigned
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review

trigger testbot for simpletest

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new notice-trying-to-get-property-of-non-object-2733095-8.patch892 bytes

rerolled the patch to get simpletest testbot to wake up.

giupenni’s picture

giupenni commented

#8 fix for me.

Thanks

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new notice-trying-to-get-property-of-non-object-2733095-10.patch988 bytes

While the other patch might have gotten rid of the notice when the key is invalid, this one should at least return something of a term name when the key is invalid.

nikolino’s picture

nikolino commented

I tried to apply the patch but I keep giving that error.
Any ideas?
Thanks

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

try applying the patch to the latest 7.x-1.x dev version of i18n, or the latest release version.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Priority: Critical » Minor

I wouldn't say this is critical.

as it's just a notice.

But the patches above don't look right.

rajiv.singh’s picture

rajiv.singh commented
StatusFileSize
new notice-trying-to-get-property-of-non-object-2733095-14.patch893 bytes

Re Rolled Patch #8 for v. 7.x-1.25

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I don't like the patch, seems wrong to me.
what should the return value be when the condition is FALSE ?

wOOge’s picture

wOOge commented

Should there even be something returned? I don't think so.

wOOge’s picture

wOOge commented

I can confirm patch in #14 works.