I'm trying to delete an environment in devshop and the "Delete backups" task is failing...
I think it's because there are no "task args" for some reason.
This is preventing it from destroying the site, also blocking any further action on the site.
Patch and branch to be submitted shortly, suggesting changing from "drush_set_error()" to drush_log() with a warning.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | provision_backup_delete-2731471-17.patch | 595 bytes | helmo |
| #10 | provision-require_backup_delete_args-2731471-9.patch | 2.52 KB | ergonlogic |
Comments
Comment #2
jon pughComment #4
jon pughAttaching a patch for hosting.module that prevents a warning caused by the missing task_args.
Comment #6
gboudrias commentedThanks. Looks good, branch is merged, please delete.
Comment #7
jon pughDone. Thanks!
Comment #8
ergonlogicWait... When called without args
backup-deleteought to fail. Why would it do otherwise? If you don't have any backups to delete, just don't call it.I think these should be reverted and fixed wherever
backup-deleteis being called without args.Comment #10
ergonlogicAs per my above comment, I reverted commits 8be5c9a144 (from Provision) and 0f348e0f027 (from Hosting). They serve only to mask the underlying problem. I think we should take the opposite approach, as per the patch attached, and make the argument to backup-delete mandatory, which it always has been, really.
Presumably this is where the DevShop environment is being deleted? Take a look at these, as we now enqueue backups to be deleted on deletion of a site, under some circumstances: hosting_site_form_hosting_task_confirm_form_alter() and hosting_site_post_hosting_backup_delete_task().
Comment #11
ergonlogicThere's a patch in #10 that requires review.
Comment #12
helmo commentedmakes sense
Comment #14
helmo commentedComment #16
jon pughThis wasn't fixed, it was reverted, which is disappointing.
This is not just covering up an underlying problem. This is a part of the problem. If a site installation fails, you should be able to delete it and it's backups, even though there are no files to delete.
When an installation fails, you are stuck with the site. The "Delete site" task will fail, and if you have the setting for it, the "Delete backups" task will fail as well.
Comment #17
helmo commented@Jon Pugh what about this patch. It think that it addresses the root cause here.
Comment #18
helmo commentedMoving to the hosting project as the new patch belongs there.
Comment #19
ergonlogicThis looks reasonable.
Comment #20
jon pughYep, that looks like it!
Thanks, Helmo.
Comment #22
helmo commentedcommitted