After I was able to initially run tests via run-test.sh, I encountered a significant amount of errors regarding schemas, e.g.:

 Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
    ldap_user.settings with the following errors:
    ldap_user.settings:ldap_user_conf.ldapEntryProvisionServer missing schema,
    ldap_user.settings:ldap_user_conf.drupalAcctProvisionTriggers missing
    schema, ldap_user.settings:ldap_user_conf.ldapEntryProvisionTriggers
    missing schema,
    ldap_user.settings:ldap_user_conf.orphanedDrupalAcctBehavior missing
    schema, ldap_user.settings:ldap_user_conf.orphanedCheckQty missing schema,
    ldap_user.settings:ldap_user_conf.userConflictResolve missing schema,
    ldap_user.settings:ldap_user_conf.manualAccountConflict missing schema,
    ldap_user.settings:ldap_user_conf.acctCreation missing schema,
    ldap_user.settings:ldap_user_conf.ldapUserSynchMappings missing schema in
    Drupal\Core\Config\Testing\ConfigSchemaChecker->onConfigSave() (line 98
    of
CommentFileSizeAuthor
#4 incomplete_schema-2730937-4.patch4.2 KBqueenvictoria
#2 incomplete_schema-2730937-2.patch4.93 KBgrahl

Comments

grahl created an issue. See original summary.

grahl’s picture

grahl
he/him
Location Zürich
commented
StatusFileSize
new incomplete_schema-2730937-2.patch4.93 KB

Attached is a patch once those are mostly fixed (at least in the ldap_user test I used as a base).

Please note that especially for ldap_user I just gave string to the missing elements, though most are likely integer or boolean, feel free to update those, if you are certain those are not set to more complex types later on.

grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Active » Needs review
queenvictoria’s picture

queenvictoria commented
StatusFileSize
new incomplete_schema-2730937-4.patch4.2 KB

I've updated ldap_user with integers, sequences and mappings where appropriate. I can't find run-test.sh--could you test the patch or let me know how to do it please?

Status: Needs review » Needs work

The last submitted patch, 4: incomplete_schema-2730937-4.patch, failed testing.

The last submitted patch, 4: incomplete_schema-2730937-4.patch, failed testing.

The last submitted patch, 4: incomplete_schema-2730937-4.patch, failed testing.

The last submitted patch, 4: incomplete_schema-2730937-4.patch, failed testing.

The last submitted patch, 4: incomplete_schema-2730937-4.patch, failed testing.

The last submitted patch, 4: incomplete_schema-2730937-4.patch, failed testing.

The last submitted patch, 4: incomplete_schema-2730937-4.patch, failed testing.

queenvictoria’s picture

queenvictoria commented
Status: Needs work » Needs review

  • grahl committed c1c3dfb on 8.x-3.x authored by queenvictoria 
    Issue #2730937 by grahl, queenvictoria: Incomplete schema definitions
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs review » Closed (fixed)

Thanks for your help queenvictoria, the test ran with your changes so I committed them.

You can find run-test.sh in core/scripts.