Currently, the 8.x-1.x branch has test failures. It appears they are due to a key "non_rev_field" being added and is breaking the normalizer tests.

While the resolution I'm going with is to update the tests, it may be the code needs to change instead. We can identify that below.

CommentFileSizeAuthor
#4 2730577.patch1.71 KBjosephdpurcell
#2 empty-patch.patch148 bytesjosephdpurcell

Comments

josephdpurcell created an issue. See original summary.

josephdpurcell’s picture

josephdpurcell commented
StatusFileSize
new empty-patch.patch148 bytes

Adding an empty patch to show the tests are failing.

josephdpurcell’s picture

josephdpurcell commented
Status: Active » Needs review

Setting to needs review to kick off tests.

josephdpurcell’s picture

josephdpurcell commented
StatusFileSize
new 2730577.patch1.71 KB

Right. So, tests fail for reasons other than the patch I'm about to submit. Tests do pass here, however: https://github.com/relaxedws/drupal-replication/pull/7

And this is the patch.

The last submitted patch, 2: empty-patch.patch, failed testing.

The last submitted patch, 2: empty-patch.patch, failed testing.

The last submitted patch, 2: empty-patch.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2730577.patch, failed testing.

The last submitted patch, 4: 2730577.patch, failed testing.

The last submitted patch, 4: 2730577.patch, failed testing.

josephdpurcell’s picture

josephdpurcell commented
Status: Needs work » Needs review

It looks like this does in fact fix the normalizer tests. Compare the 8.x-1.x branch run:
https://www.drupal.org/pift-ci-job/293961
with the patch:
https://www.drupal.org/pift-ci-job/294015

Setting to needs review.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.