Debian upgrade error 3.4 to 3.5 (hosting_git)

Ouch, forgot to report this! We have seen this on BOA already.

It is a direct result of these two commits:

http://drupalcode.org/project/hosting_git.git/commit/4d88d2a
http://drupalcode.org/project/hosting_git.git/commit/be99788

This issue should be moved to https://www.drupal.org/project/hosting_git perhaps?

Plus, https://www.drupal.org/project/hosting_git after these commits no longer works! The Git tasks are greyed out as unavailable.

We had to revert to previous version to make it work.

tested, and confirmed that the patch in #5 works nicely.

Re. #6, this is really an issue about stability upgrading the hostmaster site in general. So this is a good change either way. As a follow-up, we should probably split out the common code into a separate function.

Re. #7, hosting_git works for me with those commits. But if you're seeing issues, then that would be a separate issue for hosting_git :)

For me I was receiving the following error when I do the apt-get upgrade because of this issue.

PHP Fatal error:  Cannot redeclare drush_provision_pre_provision_git_pull() (previously declared in /var/aegir/hostmaster-7.x-3.4/profiles/hostmaster/modules/aegir/hosting_git/drush/provision_git.drush.inc:131) in /var/aegir/hostmaster-7.x-3.5/profiles/hostmaster/modules/aegir/hosting_git/pull/drush/provision_git_pull.drush.inc on line 27
Drush command terminated abnormally due to an unrecoverable error.   [error]
Error: Cannot redeclare drush_provision_pre_provision_git_pull()
(previously declared in
/var/aegir/hostmaster-7.x-3.4/profiles/hostmaster/modules/aegir/hosting_git/drush/provision_git.drush.inc:131)
in
/var/aegir/hostmaster-7.x-3.5/profiles/hostmaster/modules/aegir/hosting_git/pull/drush/provision_git_pull.drush.inc,
line 27
The external command could not be executed due to an application     [error]
error.

I can report that the patch in #2729891-5 to Drush works beautifully!

I don't know if this warrants a new issue but the stable repo is upgrading things to unstable versions**:

aegir@vps59087:~$ cat /etc/apt/sources.list.d/debian_aegirproject_org.list 
deb http://debian.aegirproject.org stable main

aegir@vps59087:~$ ls -alh /var/aegir/
[...]
drwxr-xr-x  9 aegir aegir 4.0K Nov 10  2015 hostmaster-7.x-3.2
drwxr-xr-x  9 aegir aegir 4.0K Feb 24 14:51 hostmaster-7.x-3.x-2016-05-23-1339
[...]

This hotfix (in Provision) breaks upgrade from Aegir 2.x

http://cgit.drupalcode.org/provision/commit/?id=c4d8621
http://cgit.drupalcode.org/provision/commit/?id=424298a

It results with:

  views_view
  vocabulary
  vocabulary_node_types
Drush bootstrap phase : bootstrap_drupal_full() [8.4 sec, 8.67 MB]                                                                   [bootstrap]
exception 'PDOException' with message 'SQLSTATE[42S02]: Base table or view not found: 1146 Table 'o5tquadtto8io_0.blocked_ips'           [error]
doesn't exist' in /data/disk/o5t/aegir/distro/002/includes/database/database.inc:2171
Stack trace:
#0 /data/disk/o5t/aegir/distro/002/includes/database/database.inc(2171): PDOStatement->execute(Array)
#1 /data/disk/o5t/aegir/distro/002/includes/database/database.inc(683): DatabaseStatementBase->execute(Array, Array)
#2 /data/disk/o5t/aegir/distro/002/includes/database/database.inc(2350): DatabaseConnection->query('SELECT 1 FROM {...', Array,
Array)
#3 /data/disk/o5t/aegir/distro/002/includes/bootstrap.inc(1935): db_query('SELECT 1 FROM {...', Array)
#4 /data/disk/o5t/aegir/distro/002/includes/bootstrap.inc(1948): drupal_is_denied('127.0.0.1')
#5 /data/disk/o5t/aegir/distro/002/includes/bootstrap.inc(2399): drupal_block_denied('127.0.0.1')
#6 /data/disk/o5t/aegir/distro/002/includes/bootstrap.inc(2254): _drupal_bootstrap_page_cache()
#7 /data/disk/o5t/tools/drush/lib/Drush/Boot/DrupalBoot7.php(85): drupal_bootstrap(7)
#8 /data/disk/o5t/tools/drush/includes/bootstrap.inc(354): Drush\Boot\DrupalBoot7->bootstrap_drupal_full()
#9 /data/disk/o5t/.drush/sys/provision/platform/deploy.provision.inc(169): drush_bootstrap(5)
#10 [internal function]: drush_provision_drupal_provision_deploy('/data/disk/o5t/...')
#11 /data/disk/o5t/tools/drush/includes/command.inc(366): call_user_func_array('drush_provision...', Array)
#12 /data/disk/o5t/tools/drush/includes/command.inc(217): _drush_invoke_hooks(Array, Array)
#13 [internal function]: drush_command('/data/disk/o5t/...')
#14 /data/disk/o5t/tools/drush/includes/command.inc(185): call_user_func_array('drush_command', Array)
#15 /data/disk/o5t/tools/drush/lib/Drush/Boot/BaseBoot.php(67): drush_dispatch(Array)
#16 /data/disk/o5t/tools/drush/includes/preflight.inc(66): Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#17 /data/disk/o5t/tools/drush/drush.php(12): drush_main()
#18 {main} [8.46 sec, 10.33 MB]
Changes made in drush_provision_drupal_pre_provision_deploy have been rolled back. [8.46 sec, 11.41 MB]                                  [debug]
Dropping database o5tquadtto8io_0 [8.46 sec, 11.42 MB]                                                                                  [notice]

I think we may want to revert this patch, and just update the release notes to highlight the need to disable hosting_git (if it's in use) prior to the upgrade.

Re #15, Has this issue been addressed?

I had the same problem when using apt-get upgrade from 7.x-3.4 to 7.x-3.5.

The script created a hostmaster using the 7.x-3.x dev branch similar to your output. Automated backups stopped working also. This happened on 2 different server instances. Both had identical behavior.

Seems like the upgrade removed the cron entry... Not sure if this is related to this issue though.

Has the issue been addressed with aegir3 upgrade to unstable versions?

Maybe there are more reliable checks to use, but we could just check (early enough) if some D6 specific table exists, which doesn't exist in D7. Or if some D7 specific table already exists. Something like:

if (db_table_exists('node_revisions')) {
  ### this is Aegir 2.x, because in D7 it was renamed to node_revision
}

or

if (db_table_exists('field_data_body')) {
  ### this is Aegir 3.x
}

Hmm.. but in function drush_provision_drupal_provision_deploy() it is apparently too late for this type of check.

There's a VERSION constant: https://api.drupal.org/api/drupal/modules%21system%21system.module/const......

Yes, checking VERSION is even simpler, just not sure which check will work reliably when we are already in function drush_provision_drupal_provision_deploy().