Problem/Motivation

Modules are supposed to provide a Help text page per the HELP standards for Core and Contrib, but there is none for Metatag.

Proposed resolution

Write a help text according to https://www.drupal.org/node/632280

Remaining tasks

User interface changes

Improves the UI

CommentFileSizeAuthor
#10 Screenshot from 2016-05-16 16:26:36.png162.76 KBneerugarg
#7 metatag-n2725989-7.patch2 KBdamienmckenna
#6 Screenshot from 2016-05-16 16:01:25.png173.34 KBneerugarg
#2 2725989-Add_Metatag_HELP-2.patch1.97 KBdbt102

Comments

dbt102 created an issue. See original summary.

dbt102’s picture

dbt102 commented
StatusFileSize
new 2725989-Add_Metatag_HELP-2.patch1.97 KB
dbt102’s picture

dbt102 commented
Assigned: dbt102 » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2725989-Add_Metatag_HELP-2.patch, failed testing.

The last submitted patch, 2: 2725989-Add_Metatag_HELP-2.patch, failed testing.

neerugarg’s picture

neerugarg commented
Assigned: Unassigned »
Status: Needs work » Closed (works as designed)
StatusFileSize
new Screenshot from 2016-05-16 16:01:25.png173.34 KB

I have reviewed the above mentioned issue and its working fine, Kindly check the attached screenshot.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Closed (works as designed) » Needs review
StatusFileSize
new metatag-n2725989-7.patch2 KB

This does improve the help text, so lets see if we can get the tests to pass.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: » Unassigned
neerugarg’s picture

neerugarg commented

I have reviewed the patch as well and its working fine, except 'Url::fromRoute('entity.metatag_defaults.collection')->toString()' and 'Url::fromRoute('entity.metatag_defaults.add_form')->toString()', just need to review these values.

neerugarg’s picture

neerugarg commented
StatusFileSize
new Screenshot from 2016-05-16 16:26:36.png162.76 KB

The patch is working fine, I have tested., check screen shot attached.

dbt102’s picture

dbt102 commented
Status: Needs review » Reviewed & tested by the community

@neerusrijan ... Thanks for the testing/review.

@DamienMcKenna ... What did you do to get the testing to work?

marking as RTBC

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Oddly enough, testbot was just complaining about trailing whitespace on a line, other than that it was fine.

dbt102’s picture

dbt102 commented

cool

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.