Incorrect variable name '$url1'. Actually, it should be '$url'.

File: \yubikey.pages.inc
Function: yubikey_admin_settings_validate()

It's like error in error(error message). ha ha ha :)

CommentFileSizeAuthor
#15 yubikey-undefined_variable-2724611-15-7.x-2.x.patch984 bytessandip27
#10 yubikey-undefined_variable-2724611-6-7.x-2.x.patch1.32 KBsandip27
#8 yubikey-undefined_variable-2724611-6-7.x-2.x.patch1.32 KBsandip27
#2 yubikey-undefined_variable-2724611-2-7.x-2.x.patch1.26 KBimmanuel.paul

Comments

bhavikshah9 created an issue. See original summary.

immanuel.paul’s picture

immanuel.paul commented
StatusFileSize
new yubikey-undefined_variable-2724611-2-7.x-2.x.patch1.26 KB

The error is fixed. The patch also includes some updates accounting to Coding Standards.

Kindly validate and let me know if it works.

Thanks
Immanuel Paul

bhavikshah9’s picture

bhavikshah9 commented

@immanuel.paul: Your patch resolves the issue. But, if you have time, can you please check the entire message? I think, message is weird and something is in-correct. I have noticed this after I posted the issue here. It would be great if you can fix that as well.

immanuel.paul’s picture

immanuel.paul commented

Hi Bhavik Shah,

The Error message I receive when an invalid URL is provided is as follows:

The URL #1 example.com is not valid.

I am not sure as to what is weird in this message. Can you please provide more information.

Thanks
Immanuel Paul

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented

I guess @bhavik is pointing to this #%d (just guess)

bhavikshah9’s picture

bhavikshah9 commented

@immanuel.paul, @joshi.rohit100: No. I was referring to `name`(first) parameter to `form_set_error`.
File: yubikey\yubikey.pages.inc - line#611.
'yubikey_valserver][urls][' . $i doesn't makes any sense to me and that is what I am talking about.

Thank you both for your time and efforts.

bhavikshah9’s picture

bhavikshah9 commented
Assigned: bhavikshah9 » Unassigned
sandip27’s picture

sandip27 commented
StatusFileSize
new yubikey-undefined_variable-2724611-6-7.x-2.x.patch1.32 KB

Hi bhavikshah9,

Please check the attached patch for the issues you mentioned. It should solve the problem.

Thanks

sandip27’s picture

sandip27 commented
Status: Active » Needs review
sandip27’s picture

sandip27 commented
StatusFileSize
new yubikey-undefined_variable-2724611-6-7.x-2.x.patch1.32 KB

Hi bhavikshah9,

Please check the attached updated patch for the issues you mentioned. It should solve the problem.

Thanks

sandip27’s picture

sandip27 commented
Assigned: Unassigned » sandip27
sandip27’s picture

sandip27 commented

@Maintainers, would be glad to see this patch reviewed and merged for syntactical error in module.

Thanks

  • toddejohnson committed 6ec206a on 7.x-2.x 
    Issue #2724611 by sandip27 : Fixed Undefined Variable and Syntax error...
toddejohnson’s picture

toddejohnson commented
Status: Needs review » Fixed

I've commited the patch and this issue should be resolved in the next dev build.

sandip27’s picture

sandip27 commented
Status: Fixed » Needs review
StatusFileSize
new yubikey-undefined_variable-2724611-15-7.x-2.x.patch984 bytes

Hi Todd,

Thanks for committing the patch. However, I figured some minor issue needed to be taken care of. Attaching patch for the same. Please review and merge the same.

Thanks

sandip27’s picture

sandip27 commented
Assigned: sandip27 » Unassigned
sandip27’s picture

sandip27 commented
Priority: Normal » Major

  • nevergone committed d805207 on 7.x-2.x authored by sandip27 
    Issue #2724611 by sandip27: Undefined variable in error message
nevergone’s picture

nevergone
Primary language Hungarian
commented
Status: Needs review » Fixed

Thanks, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.