workflow_execute_transition() does not respect FORCE parameter

It seems that the call to workflow_entity_field_save takes care of the transition and field value. Not sure if the fix should be in workflow_entity_field_save or workflow_execute_transition. But something like this could be done in workflow_execute_transition:

function workflow_execute_transition($entity_type, $entity, $field_name, $transition, $force = FALSE) {
  // $todo D8: Remove first 3 parameters - they can be extracted from $transition.

  // Make sure $force is set in the transition, too.
  if ($force) {
    $transition->force($force);
  }

  if ($field_name) {
    // @todo: use $new_sid = $transition->execute() without generating infinite loops.

--->
  $new_sid = $transition->execute($force);
  if(!$force and ($new_sid != $transition->sid)) {
      // Transition was not valid. Return without changing the field value.
      return $new_sid;
    }
  }
<---
    // Do a separate update to update the field (Workflow Field API)
    // This will call hook_field_update() and WorkflowFieldDefaultWidget::submit().
    $langcode = $transition->language;
-->
// Remove the following since transition was executed above
//    $entity->{$field_name}[$langcode][0]['transition'] = $transition;
<--
    $entity->{$field_name}[$langcode][0]['value'] = $transition->new_sid;
    // Save ony the field, not the complete entity.
    workflow_entity_field_save($entity_type, $entity, $field_name, $langcode, FALSE);

    $new_sid = workflow_node_current_state($entity, $entity_type, $field_name);
  }
  else {
    // For Node API, the node is not saved, since all fields are custom.
    $new_sid = $transition->execute($force = TRUE);
  }

  return $new_sid;
}

Hello Johnv

Yes this is done programmatically, through action/triggers. The state change of one workflow field will change the workflow field state of other nodes in my use case.

Thanks!

OK thanks for the info. What do you think about this fix though? Passing the $force boolean leads to think that this method will properly handle the transition which is not the case if force is FALSE...

I would be glad to help... If I understand you, I should not rely on $transition->execute($force) to validate the transition but should call WorkflowState::getOptions beforehand to check the validity? Is that what the commit you're looking for was about?

I think this function presumes that the transition is going to be executed. The proposed change is to bail out if the transition does not go through.