Closed (fixed)
Project:
DropzoneJS
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 May 2016 at 14:37 UTC
Updated:
2 Mar 2017 at 13:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
primsi commentedThis would need a re-roll, than we can continue.
Comment #3
chr.fritschComment #4
joehoppe commentedworked together with michaellenahan and Thomas Schuh at dcmuc16.
We did a reroll and the update hook. Here is the pull request: https://github.com/drupal-media/dropzonejs/pull/35
Unfortunately the travis test failed so we gonna fix that test Drupal\Tests\dropzonejs\Kernel\DropzoneJsUploadControllerTest::testDropzoneJsUploadController
Comment #5
joehoppe commentedthis is the failing patch
Comment #6
joehoppe commentedWe found the reason for the test failing. We need to do the installConfig see some examples here: https://api.drupal.org/api/drupal/core%21tests%21Drupal%21KernelTests%21...
It seems that the KernelTest needs to be told about the configuration.
The test pass in php but ont in hhvm. See https://travis-ci.org/drupal-media/dropzonejs/builds/180464022
Comment #7
michaellenahan commentedComment #10
joehoppe commentedupdated patch with working test file
Comment #11
slasher13Comment #12
chr.fritschThis patch needed a re-roll
Comment #13
primsi commentedJust two things:
I found one other instance of tmp_dir:
src/Element/DropzoneJs.php:139: $tmp_override = \Drupal::config('dropzonejs.settings')->get('tmp_dir');
I am not sure about naming this upload_scheme, from that we do not actually know that we are configuring the temporary upload location. Maybe tmp_upload_scheme?
Comment #14
chr.fritschAddressed the comments from #13
Comment #16
chr.fritschCommitted and pushed.
Thanks everyone.
Comment #17
chr.fritsch