Help hook is not there in Link module. Help hook helps user how to configure and use the module.

CommentFileSizeAuthor
#5 Screen Shot 2016-05-13 at 1.45.53 PM.png88.15 KBrahul.shinde
#5 Screen Shot 2016-05-13 at 1.42.05 PM.png49.89 KBrahul.shinde
#2 help_hook_is_not_there-2723993-2.patch2.9 KBdhruveshdtripathi

Comments

dhruveshdtripathi created an issue. See original summary.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Assigned: dhruveshdtripathi » Unassigned
StatusFileSize
new help_hook_is_not_there-2723993-2.patch2.9 KB

Help hook implemented

jeevanbhushetty’s picture

jeevanbhushetty commented
Status: Active » Needs review
rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Status: Needs review » Reviewed & tested by the community
rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2016-05-13 at 1.42.05 PM.png49.89 KB
new Screen Shot 2016-05-13 at 1.45.53 PM.png88.15 KB
dhruveshdtripathi’s picture

dhruveshdtripathi commented
dhruveshdtripathi’s picture

dhruveshdtripathi commented
dhruveshdtripathi’s picture

dhruveshdtripathi commented
renatog’s picture

renatog commented
Assigned: Unassigned » renatog

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +ciandt-contrib

Fixed.

Commited in dev branch.

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Anonymous’s picture

Anonymous (not verified) commented

Configuration is only slightly more complicated than a text field. Link text titles for URLs can be made required, set as instead of URL, optional (default), or left out entirely. If no link text title is provided, the trimmed version of the complete URL will be displayed. The target attribute should be set to "_blank", "top", or left out completely (checkboxes provide info). The rel=nofollow attribute prevents the link from being followed by certain search engines.

It could be improved and changed to

Configuration is similar to text field. Link text titles (Displayed instead of actual URL) for URLs can be made required, set as instead of URL, optional (default), or URL can displayed instead of link text. If no link text title is provided, the trimmed version of the complete URL will be displayed. The target attribute should be set to "_blank", "top", or left out completely (checkboxes provide info). The rel=nofollow attribute prevents the link from being followed by certain search engines.

Should i open a follow up or i will get maintainer's opinion in this issue only??
Thank You.