When using the Custom CDN provider, our custom CSS assets are not getting added/loaded.

CommentFileSizeAuthor
#2 custom_cdn_provider-2723829-2.patch501 bytesjoegraduate

Comments

joegraduate created an issue. See original summary.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
StatusFileSize
new custom_cdn_provider-2723829-2.patch501 bytes

The attached patch fixes the issue for me.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Active » Needs review
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

Works for me too.

  • markcarver committed 263f605 on 8.x-3.x authored by joegraduate 
    Issue #2723829 by joegraduate: Custom CDN provider plugin does not load...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

I'd rather not change the method signature (which extends from an interface). So I kept the same concept, but just modeled it after \Drupal\bootstrap\Plugin\Provider\ProviderBase::getAssets and checked if it's not set:

    // If no type is set, return all CSS and JS.
    if (!isset($types)) {
      $types = ['css', 'js'];
    }
    $types = is_array($types) ? $types : [$types];

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.