The theme has been ported into D8 version in CI&T China D8 hackathon. Now, we attach the patch for reviewing.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | Port_Corporate_Clean_to_D8-2723791-9.patch | 114.25 KB | ramdas gaikar |
| corporateclean-port-to-d8.patch | 152.92 KB | allen_cit |
Comments
Comment #2
adammaloneUnassigning this so the Corporate Clean team can evaluate this request. Can we also get an 8.x branch added to the theme so we can work against that please?
Comment #3
adammaloneComment #4
adammaloneCorporate Clean maintainers, do we need to do any more work on this to try and apply to patch and push it into the supported module?
Comment #5
yechaozheng commented@typhonius do you have any suggestion about what we can do now to push this code into 8.x?
Comment #6
alexandreracine commentedDid someone tested this patch?
This would be the first step and then I'll contact the maintainers.
I personnaly currently do not have a D8 installation, but I'll contact the maintainers if someone tryed it and if it is working.
Thanks.
Comment #7
alexandreracine commentedI have contacted George Tsopouridis to see if he would push this. I'll wait at least 2 weeks for an answer, if nothing happens, I'll ask Drupal moderators.
Comment #8
yechaozheng commentedHi Alexandreracine,
I'm with the patch's author (Allen). We have tested this patch before making the patch and it's working fine.
Thanks for your help.
Thanks,
Cato
Comment #9
ramdas gaikar commentedHello Team,
I am attaching new patch. Please review it.
Thanks.
Comment #10
ramdas gaikar commentedComment #11
ramdas gaikar commentedComment #12
ramdas gaikar commentedHello,
Is anyone looking at the Drupal 8 porting of the above theme?
thanks.
Comment #13
imshivani commented@Ramdas Gaikar, patch didn't work for me.
Comment #14
prashant.cTried to apply both patches submitted by @allen_cit and @Ramdas Gaikar.
There is lot of work needs to be done for the same.
@imshivani
It would be great if you can work on the starting skeleton for D8 version of this theme.
Comment #15
imshivani commented@Prashant.c Okay!!
Comment #16
dcamburn commentedAnyone know if this is going to get ported still?
Comment #17
djsagar commentedI have started working on D8 port for this theme. Will be checking all the patches provided for D8 port and work on changes which are needed in it to finalise D8 port.
Comment #18
djsagar commentedHere is the repo link with D8 port: https://github.com/djsagar/corporateclean
Comment #19
gaurav.kapoor commentedLet's get code pushed from https://github.com/djsagar/corporateclean to 8.x-1.x branch. Anyone still maintaining this theme?