The theme has been ported into D8 version in CI&T China D8 hackathon. Now, we attach the patch for reviewing.

Comments

allen_cit created an issue. See original summary.

adammalone’s picture

Assigned: allen_cit » Unassigned

Unassigning this so the Corporate Clean team can evaluate this request. Can we also get an 8.x branch added to the theme so we can work against that please?

adammalone’s picture

Title: Port Corporate Clean to d8 and attach the patch » [Patch attached] Port Corporate Clean to D8
adammalone’s picture

Corporate Clean maintainers, do we need to do any more work on this to try and apply to patch and push it into the supported module?

yechaozheng’s picture

@typhonius do you have any suggestion about what we can do now to push this code into 8.x?

alexandreracine’s picture

Did someone tested this patch?

This would be the first step and then I'll contact the maintainers.

I personnaly currently do not have a D8 installation, but I'll contact the maintainers if someone tryed it and if it is working.

Thanks.

alexandreracine’s picture

I have contacted George Tsopouridis to see if he would push this. I'll wait at least 2 weeks for an answer, if nothing happens, I'll ask Drupal moderators.

yechaozheng’s picture

Hi Alexandreracine,

I'm with the patch's author (Allen). We have tested this patch before making the patch and it's working fine.
Thanks for your help.

Thanks,
Cato

ramdas gaikar’s picture

StatusFileSize
new114.25 KB

Hello Team,

I am attaching new patch. Please review it.

Thanks.

ramdas gaikar’s picture

Priority: Major » Critical
Status: Needs review » Patch (to be ported)
ramdas gaikar’s picture

Status: Patch (to be ported) » Needs review
ramdas gaikar’s picture

Hello,

Is anyone looking at the Drupal 8 porting of the above theme?

thanks.

imshivani’s picture

@Ramdas Gaikar, patch didn't work for me.

prashant.c’s picture

Status: Needs review » Needs work

Tried to apply both patches submitted by @allen_cit and @Ramdas Gaikar.

There is lot of work needs to be done for the same.

@imshivani

It would be great if you can work on the starting skeleton for D8 version of this theme.

imshivani’s picture

@Prashant.c Okay!!

dcamburn’s picture

Anyone know if this is going to get ported still?

djsagar’s picture

Assigned: Unassigned » djsagar

I have started working on D8 port for this theme. Will be checking all the patches provided for D8 port and work on changes which are needed in it to finalise D8 port.

djsagar’s picture

Here is the repo link with D8 port: https://github.com/djsagar/corporateclean

gaurav.kapoor’s picture

Let's get code pushed from https://github.com/djsagar/corporateclean to 8.x-1.x branch. Anyone still maintaining this theme?