The link part of '@entity added to @cart-link.' is untranslatable, as the link is built with a non-translatable 'your cart' string.

Patch is on the way...

CommentFileSizeAuthor
#2 add_to_cart_msg_translation-2722399-2.patch633 bytesagoradesign
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agoradesign created an issue. See original summary.

agoradesign’s picture

agoradesign CreditAttribution: agoradesign commented
Status: Active » Needs review
FileSize
add_to_cart_msg_translation-2722399-2.patch633 bytes

So, here's my tiny patch. I've added a context to the translation, as in other languages than English this could be important. E.g. in German you would translate "your cart" standalone as "Ihr Warenkorb", but in the context of the sentence "... added to your cart" this would be a major grammatical error - "...zu Ihrem Warenkorb..." would be correct here.

  • bojanz committed 0424bbb on 8.x-2.x authored by agoradesign 
    Issue #2722399 by agoradesign: Add to cart message is not fully...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Took the opportunity to also use $this->t() instead of t(). Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.