Closed (fixed)
Project:
Entity Print
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 May 2016 at 04:40 UTC
Updated:
30 Mar 2017 at 07:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jordanpagewhite commentedI converted entity-print--commerce-order.tpl.php to Twig.
Comment #3
benjy commentedThe commerce order sub-module doesn't work with D8 at this stage because Drupal Commerce wasn't ready when I ported the module to Drupal 8.
I think we should convert the entire module here if we want to make it work.
Comment #4
benjy commentedComment #5
jordanpagewhite commentedComment #6
benjy commentedPostponing this for now until Commerce at least gets a beta/rc
Comment #7
vasikeCommerce 2.x already in beta5
And it seems the Entity Print is desired in Commerce core - as a solution for receipts/invoicing.
So, please check the related issue - #2831952: Create an entity_print renderer for orders (to allow order PDF output) - and the patch there.
Comment #8
bojanz commentedI don't think that entity_print should ship with any Commerce-specific integration or templates, that should go in Commerce itself.
Comment #9
benjy commentedYeah agreed with @bojanz, in D7 the sub-module was simply an example of how you would go about styling a specific entity and Commerce was the sample. I'll review the core Commerce issue asap.
Comment #10
benjy commentedI realised that the sub-module still exists from the D7 days although it's non-functional. Using this issue to go ahead and remove it from the codebase entirely.
Comment #11
benjy commentedCommitted.