entity-print--commerce-order.tpl.php is still a .tpl.php file. It should be converted to Twig. Also, we need to add to the head.

CommentFileSizeAuthor
#10 2721405-10.patch3.72 KBbenjy
#2 2721405-2.patch1.18 KBjordanpagewhite

Comments

jordanpagewhite created an issue. See original summary.

jordanpagewhite’s picture

Status: Active » Needs review
StatusFileSize
new1.18 KB

I converted entity-print--commerce-order.tpl.php to Twig.

benjy’s picture

Title: Update entity_print_commerce_order template file » Update entity_print_commerce_order for Drupal 8

The commerce order sub-module doesn't work with D8 at this stage because Drupal Commerce wasn't ready when I ported the module to Drupal 8.

I think we should convert the entire module here if we want to make it work.

benjy’s picture

Status: Needs review » Needs work
jordanpagewhite’s picture

Assigned: jordanpagewhite » Unassigned
benjy’s picture

Status: Needs work » Postponed

Postponing this for now until Commerce at least gets a beta/rc

vasike’s picture

Status: Postponed » Active

Commerce 2.x already in beta5

And it seems the Entity Print is desired in Commerce core - as a solution for receipts/invoicing.
So, please check the related issue - #2831952: Create an entity_print renderer for orders (to allow order PDF output) - and the patch there.

bojanz’s picture

I don't think that entity_print should ship with any Commerce-specific integration or templates, that should go in Commerce itself.

benjy’s picture

Status: Active » Closed (won't fix)

Yeah agreed with @bojanz, in D7 the sub-module was simply an example of how you would go about styling a specific entity and Commerce was the sample. I'll review the core Commerce issue asap.

benjy’s picture

Title: Update entity_print_commerce_order for Drupal 8 » Remove entity_print_commerce_order from Drupal 8 version
Status: Closed (won't fix) » Needs review
StatusFileSize
new3.72 KB

I realised that the sub-module still exists from the D7 days although it's non-functional. Using this issue to go ahead and remove it from the codebase entirely.

benjy’s picture

Status: Needs review » Fixed

Committed.

  • benjy committed 1d88a59 on 8.x-2.x
    Issue #2721405 by benjy, jordanpagewhite, vasike, bojanz: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.