From #2720217: [meta] Clean out non-hooks from .module

CommentFileSizeAuthor
#12 remove-sms-form-2720555-12.patch9.97 KBdpi
#7 remove-sms-form.patch6.79 KBdpi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

I'll update the OP when I figure out what exactly to do. For now I'm messing around with the code.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented

I really don't understand the purpose of that sms_send_form() function. I'd just take it out. We can replace it with a proper UI module for sending sms if needed.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

I think it will end up being a helper for the gateway plugins for methods... Do we need the number field/do gateway plugins depend on "number" existing?

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

Alright might be best to remove and decide later. I think this means we remove SmsGatewayPluginInterface::sendForm().

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented

I think this means we remove SmsGatewayPluginInterface::sendForm()

Yes

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Active » Needs review
FileSize
remove-sms-form.patch6.79 KB

Status: Needs review » Needs work

The last submitted patch, 7: remove-sms-form.patch, failed testing.

The last submitted patch, 7: remove-sms-form.patch, failed testing.

The last submitted patch, 7: remove-sms-form.patch, failed testing.

The last submitted patch, 7: remove-sms-form.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
FileSize
remove-sms-form-2720555-12.patch9.97 KB

Fix issue with SMS devel not sending the message.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Needs work » Needs review

  • dpi committed 4eba469 on 8.x-1.x 
    Issue #2720555 by dpi: Remove custom send forms.

May return at a future...
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Needs review » Fixed
  • Removed functions in sms.module
  • Removed 2x usages of these functions
  • Removed sendForm from gateway interface.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.