Co Maintainer

Done!! What should I do to have you listed as comaintainer in drupal? I have never done this :)

I have at least added you to the maintainers list in the page.

I have also cleaned the maintainers list, because a lot of people were listed that had never done any maintainance. Better only have as maintainer people who are actively doing something.

Hi Farreres,

Am interested in joiing both yourself and Jeff as a comaintainer of Moneysuite. Have programmed in php since the 1990's, plus coded php systems in MVC frameworks, ie Codeigniter. Currently am looking after a few drupal sites that will use Moneysuite. Also am interested in devloping a version of Moneysuite for drupal 8. Look forward to your reply.

Jeff, yes am interested in moving moneysuite to dripal 8. Have programmed in php, mysql, js, html since the 1990's when I started to build websites. Worked with wordpress, joomla (since ver 1). Designed and coded various online db systems for use by employment consultants, maintained and updated Codeigniter system for users across the country (approx 1000 users). For the past year have worked with drupal and some wordpress.

Looked at drupal commerce and IMHO its too complex. Don't have a current github account, though you can view my profile on linkedin.

Clivem, I can't say anything more than WELCOME!!
I don't really care what you can tell us about your past experience or whether you have a github account, I myself didn't have one when I created moneysuite project. Anyone showing interest is welcome.
I have already added you as maintainer. Just, make sure you learn how things are done in Drupal so you break nothing. I am myself still learning and I have broken things sometimes :(

Farreres, thanks for the welcome message. Understanding how things work in drupal is going to be a learning curve, what I suggest is I start with a non critical problems in Moneysuite, which do you suggest? Am open tot any ideas you guys can give in what I need to have setup, beyond a github account to start with maintaining the drupal 7 version. For the new version have started some initial planning though any thoughts suggestions, ideas on improving moneysuite are more than welcome.

Clivem, just pick any of the open issues in the issue queue. If you can't solve it in short time just jump to the next. I would suggest starting with correcting bugs rather than adding new functionality.

Hey Farreres, no problem had been reading through the list of issues to get a feel for the problems that occur. Will see that I can fix. thanks for the welcome Jeff.

Hi Farreres,

Have been quietly working in the background as work permits and have a new dev verison 7 of Moneysuite with most of the patches that uses have posted to the forum. My problem is when testing it gives an error message that an info file is missing if I try and add the dev version as a module, alas I cannot find the missing info file. Any suggestions?

regards

Clive

Hi Clivem,

How have you compiled this dev version? Have you patched dev with git? Or you have just patched you local version?

Info files already exist for the modules, but as I recall, info files are managed by the drupal system. The info files in local version are incomplete and drupal completes them when a version is released.

For example, for ms_core.info you get:

; Information added by Drupal.org packaging script on 2017-02-27
version = "7.x-10.x-dev"
core = "7.x"
project = "moneysuite"
datestamp = "1488183786"

You are maybe getting errors because you dev version isn't patched on dev and downloaded from drupal site.

I would apply patches one by one to dev using git and then download the generated dev to test it. Once it gives no error a new version can be released using the drupal release system.

Hi Farreres,

Thanks for the info. Yes I did add the patches on my local system as I find it easier that working with git. Will give a try though and see how I go.

Regards

Clive

Having success? I use giteye, it makes things quite easy...

Hi Farreres,

Have been delayed by a project am working on. As I freelance paying work has to take priority, and am hoping the current project has no more sudden major changes. I'll look at giteye was thinking of using the git function in Visual Studio as have just updated to a Win10 pc.

Hi Farreres,

Installed giteye today and yes its easy to use compared to using the command line options, was trying to get github working though it wouldn't allow the drupal site for some reason. Now have the repositories setup and will start testing and making the changes for a new dev version of moneysuite.

Farreres,

How do I know that giteye will commit to the dev version and not the stable version when I select Commit and Push? as it only appears to find the stable version

@Clivem: Stable and dev are managed by drupal versioning system, git know nothing about them. In git you only have one repository and you commit against this repository. Drupal interprets this repository as dev. Whenever you have a repository you consider adequate for a stable version then you tag it and a snapshot is made and a zip is compiled with a frozen image of the repository at this precise moment in time. So don't worry, you can just commit directly against 7.x-10.x. In any case, the step is to first patch your local copy and then giteye will recognize which files have changed and you can commit these changes in git staging label in giteye. Take care to add adequate references of authorship of patches. You can do this in commit message to the right of git staging screen. In order to find which data to write as a message, you'll find a box at the end of all issues in Drupal.org with the data to fill for authorship if some patch exists in this issue.

Farreres, have made a simple change to the code for a test and tried to commit the changes. The drupal system will not let myself do so as I do not have write permissions for the moneysuite repository. Who grants the permissions?

@Clivem, you need to set up a private/public RSA key pair. Then you must tell Drupal and Giteye about them. In GitEye Dashboard you can see a SSH Client settings option, and there you can ask giteye to generate a key pair or you can tell giteye to look for your keys in some directory. In Drupal if you go to your profile there is a tab named SSH keys, there you must upload your public key. I think this will solve your problems.

Farreres, have recreated keys and tried again. Still have the same results with the error message of I do not have write permissions for the moneysuite repository.

But you have write permission to CVS, as you can see in the image I am attaching. In fact you have all possible permissions...
Maybe you should consult this page https://www.drupal.org/project/moneysuite/git-instructions following it I had no problem to set up my system.

Maybe you haven't performed the one time only instruccions, I think those link your local copy to git and grant you access...

have tried this again using the instructions you sent, am not certain that my commit has worked. Can you see any commits from myself at all?

Giteye is still stating I do not have write permissions so the commit was done at the command line using a git shell.

have tried this again with giteye and still receive the same message I do not have write permissions to the moneysuite repository.

@Clivem: did you perform this step? https://www.drupal.org/node/1022156#identify-global

By the way, once you do a commit, you can check yourself here if it was successful: https://www.drupal.org/node/2490484/commits

Farreres, I've gone through all of the steps 3 times to verify I can access the system. Have run the test to make sure I can clone the examples repository that drupal have set up and all of the tests work correctly. It does not matter if I try and update the moneysuite repository via giteye, github or the git command line the error is still the same "remote error You do not have write permissions for the moneysuite repository"

The drupal site is blocking myself from updating the repository.

I have seen that others have your problem and they need to go to git access page and accept access agreement. Try in https://www.drupal.org/user/3505171/git

Farreres, I've reset my password, reset my ssh keys and made sure I have accept access agreements and still have the same error, that I do not have write permissions to the moneysuite repository. All the the git programs I've used state it is a remote error, not a local error.

I don't know what more to tell you. I only know it worked for me quite fast just following the instructions. I use linux, not windows, but this shouldn't make much of a difference. Maybe you should go ask some module developer forum here in drupal, maybe they can tell you more...

The only other thing I can think of at present is its a problem caused by my firewall. Am going to setup a local repository on another network today and test it there to see if I receive the same error.

Farreres, finally!!!!!!! I've got a commit to work please check the commits for Moneysuite as my message appears to be very different to what you have.

I ran this on a different network so its either my firewall or VPN causing the issue. Will need to investigate.

Also if have to how do I recall a commit?

@Clivem: congratulations! You finally did it. Did you do it with giteye? When I commit with giteye I do this series of steps:

1. Apply the patch to my local copy of the module
2. Check there were no errors and consistency of the code
3. Open GitEye
4. Select repostory
5. Go to git staging tab
6. Let GitEye autodetect changed files
7. Select files to move to staged changes
8. Edit commit message, author and committer
9. Commit and push

If you want to revert a commit, it is best for you to activate the history tab in giteye and watch the branches graphically. There you can then pick the commit with your mouse and with the contextual menu select revert commit.

I am not an expert in git, and it seems it's too easy to create new branches by error. I have myself done it. If you see, after I created 7.x-10.3 I tried to add events ticketing suite and I don't know why it it went to another branch, you can view it graphically in history. Then I tried to revert it and it got messed up. Anyway it seems ms_events is in current head, I don't know how... Or maybe I am wrong. You must be careful :) I am not that careful most of the time...

In your commit you didn't edit correctly the message and author. If you choose your latest commit in giteye and choose to Open in Commit Viewer you'll see the message and the author fields. You are the committer, but the author should be the person who wrote the patch, and this you can see in the drupal issue item at the bottom, in credits and committing.

Farreres, the system I was using did not have the java installs for GitEye, which looks easier to use, instead I used the Git Bash shell and the github interface. The github interface does not have the layout or features of giteye and hence I had to guess a few of the steps.

I can see how easy it would be to go wrong and was concerned that I would overwrite the wrong branch. While git looks simple its far more complex than I thought. Now I need to find out why it does not work on my pc, its either firewall or vpn causing the issue.

Thanks for all of your help with this and am hoping I can get a few more of these patches tested and added to the dev version in the near future.

Hi Farreres,

See you have replied to the security warning. Let myself know if you need any assistance.

Hi Clivem, if you read the issue, they suggest that we don't patch anything until security team tells us. We should before test that the patch solves the problem. I have no test install to do it, do you? Can you test if the patch works?

I'll test the patch today.

Farreres, I have tested the proposed change and the same issue still occurs. The security page will not let myself post a reply,, can you inform mlhess that I am still looking at the issue. Thanks Clive

have run further tests and the change does not fix the issue. We will need to look further to find an answer.

Farreres, how found a fix to the issue, requires changes to the ms_core.module and ms_core.views_default.inc code. Can you advise mlhess thanks.

Clivem, you need to fill a SA draft but I don't want to put the url here in the open. Please, send me a private message and I give you the address.

Farreres, Jeff,

We need to decide on a date to update moneysuite to install the security patch