Now that we have fancy attributes to control how the product variation selection widget renders, we should bring it to a field formatter as well. This would be a field formatter which only attaches to an entity reference field that points to commerce_product_variation.

The field formatter's settings will allow a user to pick which attributes should be rendered. It will render the default display mode.

This will allow us to fully deprecate all the functionality Commerce Fancy Attributes provided us via Field Extractor:

CommentFileSizeAuthor
#4 add_field_formatter_for-2719479-4.patch8.8 KBmglaman
#3 add_field_formatter_for-2719479-3.patch8.03 KBmglaman
To_wear___Commerce_KickStart_Demo.png1.11 MBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Assigned: Unassigned » mglaman
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented
Issue summary: View changes
FileSize
add_field_formatter_for-2719479-3.patch8.03 KB

Here is the patch to add the new formatter.

PR: https://github.com/drupalcommerce/commerce/pull/378

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented
FileSize
add_field_formatter_for-2719479-4.patch8.8 KB

Forgot the field formatter schema.

field.formatter.settings.commerce_product_attributes_overview:
  type: mapping
  mapping:
    attributes:
      type: sequence
      label: 'Attributes to render.'
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented
Status: Active » Needs work

Work ongoing in the PR.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Needs review

PR is almost ready, minor nitpicks left.

  • bojanz committed 99885d0 on 8.x-2.x authored by mglaman 
    Issue #2719479 by mglaman: Add field formatter for variations field to...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.