Dynamic routes in image styles break under pathologic

Here's a reroll of the patch against the current dev. I can confirm that setting ignore paths for /sites/default/files/* fixes the image styles problem.

This specific issue with image style URLs is only apparent when the image derivative is not yet created. Once the derivative is created (thus the derived image is available on the filesystem) pathologic does not screw up the path anymore.

Created patch checking non-file path via route-lookup if it is a image_style route.

Fixed my patch: internal:// is bad. internal:/ is better.

Slightly improved version from #19 is now also integrated in #2418369-25: Internal URL handling (language prefixes, base://, ...).
To keep things together I attach this improved version also here.

Thanks for the bug report and all the effort so far! My goal is to get #2418369: Internal URL handling (language prefixes, base://, ...) in soon, since there are a lot of bugs in the queue related to that. But it'd be great to fix this, too.

Meanwhile, I'd like to make sure our test coverage is solid, so I'm not going to commit issues that don't have tests. Tagging for that.

Thanks again,
-Derek

p.s. The title references all 'Dynamic routes' but my very quick skim of the patch and it looks like it's is hard-coded to only handle image style routes. If this is really only fixing image styles, let's update the title accordingly. If this is actually handling any other kinds of dynamic routes, can someone explain how that works? ;)

+        $cached_settings['is_file'] = $detected_route_name && strpos($detected_route_name, 'image.style_') === 0;

Thanks again,
-Derek

This patch works for me except that a language prefix is still inserted into the file path, since is_files is never actually used. I know that's not closely related to the original post here but I've added a snippet from the latest patch in #2418369: Internal URL handling (language prefixes, base://, ...) which solves that problem for me.

Rerolling patch

Rerolling for Pathologic 2.0.x branch

Added MR !17 on 2.0.x branch with the changes from #25 (without language piece)